Skip to content

Commit 7bedbb5

Browse files
committed
feat(core,driver)!: move DaffInMemoryDataServiceInterface to @daffodil/driver/in-memory
BREAKING CHANGE: `DaffInMemoryDataServiceInterface` is now exported from `@daffodil/driver/in-memory` and has been removed from `@daffodil/core/testing`
1 parent 44112b7 commit 7bedbb5

File tree

23 files changed

+66
-17
lines changed

23 files changed

+66
-17
lines changed

Diff for: libs/cart/driver/in-memory/src/backend/cart-address/cart-address.service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
} from 'angular-in-memory-web-api';
99

1010
import { DaffCart } from '@daffodil/cart';
11-
import { DaffInMemoryDataServiceInterface } from '@daffodil/core/testing';
11+
import { DaffInMemoryDataServiceInterface } from '@daffodil/driver/in-memory';
1212

1313
import {
1414
DAFF_CART_IN_MEMORY_EXTRA_ATTRIBUTES_HOOK,

Diff for: libs/cart/driver/in-memory/src/backend/cart-billing-address/cart-billing-address.service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import {
1111
DaffCart,
1212
DaffCartAddress,
1313
} from '@daffodil/cart';
14-
import { DaffInMemoryDataServiceInterface } from '@daffodil/core/testing';
14+
import { DaffInMemoryDataServiceInterface } from '@daffodil/driver/in-memory';
1515

1616
import {
1717
DAFF_CART_IN_MEMORY_EXTRA_ATTRIBUTES_HOOK,

Diff for: libs/cart/driver/in-memory/src/backend/cart-coupon/cart-coupon.service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import {
1111
DaffCart,
1212
DaffCartCoupon,
1313
} from '@daffodil/cart';
14-
import { DaffInMemoryDataServiceInterface } from '@daffodil/core/testing';
14+
import { DaffInMemoryDataServiceInterface } from '@daffodil/driver/in-memory';
1515

1616
import {
1717
DAFF_CART_IN_MEMORY_EXTRA_ATTRIBUTES_HOOK,

Diff for: libs/cart/driver/in-memory/src/backend/cart-items/cart-items.service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import {
1313
DaffCartItemInput,
1414
} from '@daffodil/cart';
1515
import { DaffCartItemFactory } from '@daffodil/cart/testing';
16-
import { DaffInMemoryDataServiceInterface } from '@daffodil/core/testing';
16+
import { DaffInMemoryDataServiceInterface } from '@daffodil/driver/in-memory';
1717
import { DaffInMemoryBackendProductService } from '@daffodil/product/driver/in-memory';
1818

1919
import { daffCartInMemoryComputeCartItemPrices } from '../../helpers/compute-cart-item-prices';

Diff for: libs/cart/driver/in-memory/src/backend/cart-order/cart-order.service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {
55
} from 'angular-in-memory-web-api';
66

77
import { DaffCartOrderResult } from '@daffodil/cart';
8-
import { DaffInMemoryDataServiceInterface } from '@daffodil/core/testing';
8+
import { DaffInMemoryDataServiceInterface } from '@daffodil/driver/in-memory';
99

1010
/**
1111
* @inheritdoc

Diff for: libs/cart/driver/in-memory/src/backend/cart-payment-methods/cart-payment-methods.service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
DaffCart,
99
DaffCartPaymentMethod,
1010
} from '@daffodil/cart';
11-
import { DaffInMemoryDataServiceInterface } from '@daffodil/core/testing';
11+
import { DaffInMemoryDataServiceInterface } from '@daffodil/driver/in-memory';
1212

1313
/**
1414
* @inheritdoc

Diff for: libs/cart/driver/in-memory/src/backend/cart-payment/cart-payment.service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import {
1111
DaffCart,
1212
DaffCartPaymentMethod,
1313
} from '@daffodil/cart';
14-
import { DaffInMemoryDataServiceInterface } from '@daffodil/core/testing';
14+
import { DaffInMemoryDataServiceInterface } from '@daffodil/driver/in-memory';
1515

1616
import {
1717
DAFF_CART_IN_MEMORY_EXTRA_ATTRIBUTES_HOOK,

Diff for: libs/cart/driver/in-memory/src/backend/cart-root.service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
} from 'angular-in-memory-web-api';
77

88
import { DaffCart } from '@daffodil/cart';
9-
import { DaffInMemoryDataServiceInterface } from '@daffodil/core/testing';
9+
import { DaffInMemoryDataServiceInterface } from '@daffodil/driver/in-memory';
1010

1111
import { DaffInMemoryBackendCartService } from './cart/cart.service';
1212
import { DaffInMemoryBackendCartAddressService } from './cart-address/cart-address.service';

Diff for: libs/cart/driver/in-memory/src/backend/cart-shipping-address/cart-shipping-address.service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import {
1111
DaffCart,
1212
DaffCartAddress,
1313
} from '@daffodil/cart';
14-
import { DaffInMemoryDataServiceInterface } from '@daffodil/core/testing';
14+
import { DaffInMemoryDataServiceInterface } from '@daffodil/driver/in-memory';
1515

1616
import {
1717
DAFF_CART_IN_MEMORY_EXTRA_ATTRIBUTES_HOOK,

Diff for: libs/cart/driver/in-memory/src/backend/cart-shipping-information/cart-shipping-information.service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import {
1111
DaffCart,
1212
DaffCartShippingRate,
1313
} from '@daffodil/cart';
14-
import { DaffInMemoryDataServiceInterface } from '@daffodil/core/testing';
14+
import { DaffInMemoryDataServiceInterface } from '@daffodil/driver/in-memory';
1515
import { DaffInMemoryBackendProductService } from '@daffodil/product/driver/in-memory';
1616

1717
import { daffCartInMemoryComputeCartTotals } from '../../helpers/compute-cart-totals';

Diff for: libs/cart/driver/in-memory/src/backend/cart-shipping-methods/cart-shipping-methods.service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {
99
DaffCartShippingRate,
1010
} from '@daffodil/cart';
1111
import { DaffCartShippingRateFactory } from '@daffodil/cart/testing';
12-
import { DaffInMemoryDataServiceInterface } from '@daffodil/core/testing';
12+
import { DaffInMemoryDataServiceInterface } from '@daffodil/driver/in-memory';
1313

1414
/**
1515
* @inheritdoc

Diff for: libs/cart/driver/in-memory/src/backend/cart/cart.service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import {
1111

1212
import { DaffCart } from '@daffodil/cart';
1313
import { DaffCartFactory } from '@daffodil/cart/testing';
14-
import { DaffInMemoryDataServiceInterface } from '@daffodil/core/testing';
14+
import { DaffInMemoryDataServiceInterface } from '@daffodil/driver/in-memory';
1515
import { DaffInMemoryBackendProductService } from '@daffodil/product/driver/in-memory';
1616

1717
import { daffCartInMemoryComputeCartTotals } from '../../helpers/compute-cart-totals';

Diff for: libs/core/testing/src/public_api.ts

-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
//@angular/core
22
export { DaffMockCurrencyPipe } from './angular/mocks/pipes/currency';
3-
export { DaffInMemoryDataServiceInterface } from './angular/interfaces/in-memory-data-service.interface';
43

54
//Core
65
export { DaffCoreTestingModule } from './testing.module';

Diff for: libs/driver/in-memory/ng-package.json

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"$schema": "../../../node_modules/ng-packagr/ng-entrypoint.schema.json",
3+
"lib": {
4+
"entryFile": "src/index.ts"
5+
}
6+
}

Diff for: libs/core/testing/src/angular/interfaces/in-memory-data-service.interface.ts renamed to libs/driver/in-memory/src/backend/data-service.type.ts

+15
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,23 @@ import { Observable } from 'rxjs';
55
* An interface for defining in memory services that use the angular in memory web api.
66
*/
77
export interface DaffInMemoryDataServiceInterface {
8+
/**
9+
* The R in CRUD.
10+
*/
811
get?(reqInfo: RequestInfo): Observable<any>;
12+
13+
/**
14+
* The C in CRUD.
15+
*/
916
post?(reqInfo: RequestInfo): Observable<any>;
17+
18+
/**
19+
* The U in CRUD.
20+
*/
1021
put?(reqInfo: RequestInfo): Observable<any>;
22+
23+
/**
24+
* The D in CRUD.
25+
*/
1126
delete?(reqInfo: RequestInfo): Observable<any>;
1227
}

Diff for: libs/driver/in-memory/src/backend/public_api.ts

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export * from './data-service.type';

Diff for: libs/driver/in-memory/src/index.ts

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export * from './public_api';

Diff for: libs/driver/in-memory/src/public_api.ts

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export * from './backend/public_api';

Diff for: libs/driver/tsconfig.json

+26
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
{
2+
"extends": "../../tsconfig.json",
3+
"compilerOptions": {
4+
"baseUrl": "../..",
5+
"paths": {
6+
"@daffodil/*": [
7+
"dist/*"
8+
],
9+
"@daffodil/driver": [
10+
"libs/driver/src"
11+
],
12+
"@daffodil/driver/hubspot": [
13+
"libs/driver/hubspot/src"
14+
],
15+
"@daffodil/driver/magento": [
16+
"libs/driver/magento/src"
17+
],
18+
"@daffodil/driver/magento/testing": [
19+
"libs/driver/magento/testing/src"
20+
],
21+
"@daffodil/driver/in-memory": [
22+
"libs/driver/in-memory/src"
23+
],
24+
}
25+
}
26+
}

Diff for: libs/driver/tsconfig.spec.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"extends": "../../tsconfig.json",
2+
"extends": "./tsconfig.json",
33
"compilerOptions": {
44
"outDir": "../../dist/out-tsc/libs/driver",
55
"types": [

Diff for: libs/geography/driver/in-memory/src/backend/geography.service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {
55
STATUS,
66
} from 'angular-in-memory-web-api';
77

8-
import { DaffInMemoryDataServiceInterface } from '@daffodil/core/testing';
8+
import { DaffInMemoryDataServiceInterface } from '@daffodil/driver/in-memory';
99
import { DaffCountry } from '@daffodil/geography';
1010
import {
1111
DaffCountryFactory,

Diff for: libs/order/driver/in-memory/src/backend/order.service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {
1010
daffIdentifiableArrayToDict,
1111
DaffSortDirectionEnum,
1212
} from '@daffodil/core';
13-
import { DaffInMemoryDataServiceInterface } from '@daffodil/core/testing';
13+
import { DaffInMemoryDataServiceInterface } from '@daffodil/driver/in-memory';
1414
import { DaffOrder } from '@daffodil/order';
1515
import { DaffOrderFactory } from '@daffodil/order/testing';
1616

Diff for: libs/reviews/driver/in-memory/src/backend/reviews.service.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {
55
STATUS,
66
} from 'angular-in-memory-web-api';
77

8-
import { DaffInMemoryDataServiceInterface } from '@daffodil/core/testing';
8+
import { DaffInMemoryDataServiceInterface } from '@daffodil/driver/in-memory';
99
import { DaffProductReviews } from '@daffodil/reviews';
1010
import { DaffProductReviewsFactory } from '@daffodil/reviews/testing';
1111

0 commit comments

Comments
 (0)