Skip to content

Commit 8968bf8

Browse files
committed
Set defaults to false for loader definitions
There isn't much value in having defaults set for descriptors What's more it causes issues when using those descriptors with protobufjs Descriptors with oneofIndex: 0, cause issues when they aren't part of a oneof
1 parent ba24f18 commit 8968bf8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/proto-loader/src/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ const descriptorOptions: Protobuf.IConversionOptions = {
148148
longs: String,
149149
enums: String,
150150
bytes: String,
151-
defaults: true,
151+
defaults: false,
152152
oneofs: true,
153153
json: true,
154154
};

0 commit comments

Comments
 (0)