Incorrect implementation of timeout = 0 in blocking calls?

[Crentist]

Blocking commands such as BLPOP and BRPOP in Redis block indefinitely when the timeout value is zero. redis-rb does the same when a timeout is not provided (it defaults to 0 and thus blocks indefinitely). This doesn't seem to be the behavior implemented by the gem:

def blpop(keys, timeout=0)
  #todo threaded mode
  keys = Array(keys)
  keys.each do |key|
    if data[key] && data[key].size > 0
      return [key, data[key].shift]
    end
  end
  sleep(timeout.to_f)
  nil
end

as it sleeps for zero seconds instead of blocking.

[guilleiguaran]

Thanks for reporting this.

Do you think you can send a PR to fix the behavior of fakeredis in this case?