feat: store localnet logs between runs, remove excessive rm and clean commands from tmp_log folder, fix promtail config to point it to the right place, add named volume to the docker-compose to store logs between runs, make debug-start-log more user-friendly

Author: mur-me

Makefile

@@ -236,7 +236,7 @@ travis_rosetta_checker:
 	TEST_REPO_BRANCH='master'
 	bash ./scripts/travis_rosetta_checker.sh
 
-debug_external: clean
+debug_external:
 	bash test/debug-external.sh
 
 build_localnet_validator:

test/debug.sh

@@ -6,7 +6,6 @@ Localnet_Blocks_Per_Epoch=$2
 Localnet_Blocks_Per_Epoch_V2=$3
 
 ./test/kill_node.sh
-rm -rf tmp_log* 2> /dev/null
 rm *.rlp 2> /dev/null
 rm -rf .dht* 2> /dev/null
 scripts/go_executable_build.sh -S || exit 1  # dynamic builds are faster for debug iteration...

test/logs_aggregator/docker-compose.yml

@@ -10,8 +10,8 @@ services:
     container_name: promtail
     image: grafana/promtail:latest
     volumes:
-      - ./promtail-config.yml:/etc/promtail/promtail-config.yaml
-      - ${CURRENT_SESSION_LOGS}:/var/log/
+      - ./promtail-config.yml:/etc/promtail/config.yml
+      - log_data:/var/log/
   grafana:
     container_name: grafana
     image: grafana/grafana
@@ -23,3 +23,11 @@ services:
       - 3000:3000
     volumes:
       - ./loki-datasource.yaml:/etc/grafana/provisioning/datasources/loki-datasource.yaml
+
+volumes:
+  log_data:
+    driver: local
+    driver_opts:
+      type: none
+      o: bind
+      device: ${LOG_FOLDER}

test/logs_aggregator/promtail-config.yml

@@ -15,4 +15,4 @@ scrape_configs:
       - "localhost"
     labels:
       job: varlogs
-      __path__: /var/log/*.log
+      __path__: /var/log/log*/*.log

test/logs_aggregator/start_log_aggregator.sh

@@ -5,13 +5,15 @@ set -eou pipefail
 DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" >/dev/null 2>&1 && pwd)"
 echo "working in ${DIR}"
 cd $DIR && pwd
-logs="$(ls -1 '../../tmp_log/')"
-path="$(readlink -f '../../tmp_log/')"
-echo "Current localnet logs are placed into '${path}/${logs}'"
-echo "CURRENT_SESSION_LOGS='${path}/${logs}'" > .env
-echo "CURRENT_SESSION_LOGS='${path}/${logs}'"
-echo "starting docker compose lor log aggregation"
+path="$(readlink -f '../../tmp_log/')/"
+loki_path="$(find ${path} -type d | sort | tail -n 1)"
+loki_path=$(echo "${loki_path}" | sed "s#.*/tmp_log/#/var/log/#")
+echo "LOG_FOLDER='${path}'" > .env
+echo "starting docker compose for log aggregation"
 docker compose up --detach
 sleep 5
+echo "Whole list of log folders"
+find ${path} -type d | sort | grep 'log-'
 echo "Opening Grafana"
 python3 -m webbrowser "http://localhost:3000/explore"
+echo "Please, use {filename=~\"${loki_path}/.*\"} to get the latest run localnet logs"