helper/schema: Compile valid field name regex once (#1062)

skarimo · web-flow · commit 3495894b26ae · 2022-10-10T15:59:58.000-04:00
diff --git a/helper/schema/schema.go b/helper/schema/schema.go
@@ -1093,9 +1093,10 @@ func checkKeysAgainstSchemaFlags(k string, keys []string, topSchemaMap schemaMap
 	return nil
 }
 
+var validFieldNameRe = regexp.MustCompile("^[a-z0-9_]+$")
+
 func isValidFieldName(name string) bool {
-	re := regexp.MustCompile("^[a-z0-9_]+$")
-	return re.MatchString(name)
+	return validFieldNameRe.MatchString(name)
 }
 
 // resourceDiffer is an interface that is used by the private diff functions.

Original file line number	Diff line number	Diff line change
`@@ -1093,9 +1093,10 @@ func checkKeysAgainstSchemaFlags(k string, keys []string, topSchemaMap schemaMap`
`1093`	`1093`	`return nil`
`1094`	`1094`	`}`
`1095`	`1095`
	`1096`	`+var validFieldNameRe = regexp.MustCompile("^[a-z0-9_]+$")`
	`1097`	`+`
`1096`	`1098`	`func isValidFieldName(name string) bool {`
`1097`		`- re := regexp.MustCompile("^[a-z0-9_]+$")`
`1098`		`- return re.MatchString(name)`
	`1099`	`+ return validFieldNameRe.MatchString(name)`
`1099`	`1100`	`}`
`1100`	`1101`
`1101`	`1102`	`// resourceDiffer is an interface that is used by the private diff functions.`