Skip to content

Commit 822997d

Browse files
Mikolajulysses4ever
andcommitted
Apply suggestions from code review
Co-authored-by: Artem Pelenitsyn <[email protected]>
1 parent b2606fe commit 822997d

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Diff for: release-notes/Cabal-3.14.2.0.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ Cabal and Cabal-syntax 3.14.2.0 changelog and release notes
1919
environment for these processes, Cabal would append the overridden environment
2020
to the existing environment, creating duplicates of the same variable.
2121

22-
- Set <pkgname>_datadir to an absolute path when running tests [#10717](https://github.com/haskell/cabal/issues/10717) [#10828](https://github.com/haskell/cabal/pull/10828)
22+
- Set `<pkgname>_datadir` to an absolute path when running tests [#10717](https://github.com/haskell/cabal/issues/10717) [#10828](https://github.com/haskell/cabal/pull/10828)
2323

2424
Fix a regression where `<pkgname>_datadir` was set to a relative path. This
2525
caused issues when running testsuites which changed the working directory and

Diff for: release-notes/cabal-install-3.14.2.0.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
The initial configuration of programs was done without the `extra-prog-path` from the global cabal configuration. This meant that in some cases, some executables were not found. In particular this manifested as Windows users who didn't add the MSYS2 paths to the global PATH couldn't make use of `pkg-config`.
88

9-
- Fix regression where build-tool-depends are not used [#10633](https://github.com/haskell/cabal/issues/10633) [#10692](https://github.com/haskell/cabal/issues/10692) [#10731](https://github.com/haskell/cabal/pull/10731)
9+
- Fix regression where `build-tool-depends` is not used [#10633](https://github.com/haskell/cabal/issues/10633) [#10692](https://github.com/haskell/cabal/issues/10692) [#10731](https://github.com/haskell/cabal/pull/10731)
1010

1111
Fixes a regression from 3.14.1.0 where a globally found executable would be found
1212
rather than a dependency specified with `build-tool-depends`.
@@ -42,7 +42,7 @@
4242
environment for these processes, Cabal would append the overridden environment
4343
to the existing environment, creating duplicates of the same variable.
4444

45-
- Deduplicate "using configuration from" message [#10546](https://github.com/haskell/cabal/pull/10546)
45+
- Deduplicate the "using configuration from" message [#10546](https://github.com/haskell/cabal/pull/10546)
4646

4747
Deduplicates and sorts the list of configuration files and URIs printed with the
4848
"using configuration from" message. This message is shown when there's a build

0 commit comments

Comments
 (0)