proxy/grpcproxy: add return on error for metrics handler

hexfusion · hexfusion · commit 7444d3ad53de · 2020-03-14T16:34:16.000-04:00
Signed-off-by: Sam Batschelet &lt;sbatsche@redhat.com&gt;
diff --git a/proxy/grpcproxy/metrics.go b/proxy/grpcproxy/metrics.go
@@ -89,6 +89,7 @@ func HandleMetrics(mux *http.ServeMux, c *http.Client, eps []string) {
 		resp, err := c.Get(target)
 		if err != nil {
 			http.Error(w, "Internal server error", http.StatusInternalServerError)
+			return
 		}
 		defer resp.Body.Close()
 		w.Header().Set("Content-Type", "text/plain; version=0.0.4")

Original file line number	Diff line number	Diff line change
`@@ -89,6 +89,7 @@ func HandleMetrics(mux http.ServeMux, c http.Client, eps []string) {`
`89`	`89`	`resp, err := c.Get(target)`
`90`	`90`	`if err != nil {`
`91`	`91`	`http.Error(w, "Internal server error", http.StatusInternalServerError)`
	`92`	`+ return`
`92`	`93`	`}`
`93`	`94`	`defer resp.Body.Close()`
`94`	`95`	`w.Header().Set("Content-Type", "text/plain; version=0.0.4")`