Skip to content

directory page grid view no longer sends a lot of get requests #11802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2025
Merged

directory page grid view no longer sends a lot of get requests #11802

merged 2 commits into from
Apr 15, 2025

Conversation

Israellund
Copy link
Collaborator

Link to Issue

Closes: #11788

Description of Changes

  • refactored code so that each CommunityDirectoryCard.tsx isn't calling useGetCommunityByIdQuery to get the community data

Test Plan

  • go to Ethereum community and go to Directory page
  • click grid view for related communities and confirm you no longer see a large amount of GET requests in the terminal

@Israellund Israellund merged commit 0071a04 into master Apr 15, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salman-neslit salman-neslit salman-neslit approved these changes

@KaleemNeslit KaleemNeslit KaleemNeslit approved these changes

@burtonator burtonator Awaiting requested review from burtonator

@masvelio masvelio Awaiting requested review from masvelio

@mzparacha mzparacha Awaiting requested review from mzparacha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate large GET request from Directory page grid view
3 participants
@Israellund @salman-neslit @KaleemNeslit