Skip to content

Uniswap Swap Modal Improvements #11813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dillchen opened this issue Apr 9, 2025 · 1 comment · Fixed by #11857
Closed

Uniswap Swap Modal Improvements #11813

dillchen opened this issue Apr 9, 2025 · 1 comment · Fixed by #11857
Assignees

Comments

@dillchen
Copy link
Contributor

dillchen commented Apr 9, 2025

Description

We want to improve the UX for a few cases for the Uniswap Swap Modal: here are the cases and the desired user behavior across the UniswapTradeModal and UniswapTrade. each

  1. If I connect with a Magic Wallet, I should auto switch networks (magic should switch chains via magicNetworkUtils file)
  • I should not need to be prompted to switch chains

Image

  1. If I connect with an address / Metamask
  • The useNetworkSwitching should pop up the provider, to “switch chains” in the provider it does not

Image

  1. If no address not logged in (it should just show the swap modal, and be directed to the correct chain and it should prompt the user to connect wallet)

The screenshot below is the current UI / UX

Image

  1. Prompt to Connect Wallet should leverage the onConnectWalletClick

https://docs.uniswap.org/sdk/swap-widget/reference/v2#optional-parameters

Ideally leverages the following

Image

**Current on click behavior: **

https://www.loom.com/share/8adf76272503420ebe10a65370816980

Image

Ideal Flow

  1. On Wallet Connect Click
  2. Opens our AuthModal
  3. Returns the injected provider (resolving promise true / false) if sign in is completed

Later

  1. If I connect I should only fetch a subset of all the network configs (major networks)

The above is a list of all supported chains

@ianrowan
Copy link
Contributor

ianrowan commented Apr 14, 2025

When I use magic it is always on the right chain for the swap - am I missing something?

Image

CC @dillchen

Update: May be due to Kurtis changes which I pulled in before starting, so I believe fixed in #11712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants