Skip to content

Commit e104bc6

Browse files
hozukihozuki
committed
[hca] Fixed DataBits index access error caused by some malformed HCA files (hozuki/libcgss#7)
1 parent 18ee3cc commit e104bc6

14 files changed

+508
-314
lines changed

‎Apps/Acb2Wavs/Program.cs

+6-1
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,12 @@ private static void ProcessAllBinaries(uint acbFormatVersion, DecodeParams baseD
162162
File.Delete(extractFilePath);
163163
}
164164

165-
Console.WriteLine(ex.Message);
165+
Console.WriteLine(ex.ToString());
166+
167+
if (ex.InnerException != null) {
168+
Console.WriteLine("Details:");
169+
Console.WriteLine(ex.InnerException.ToString());
170+
}
166171
}
167172
} else {
168173
Console.WriteLine("skipped (not HCA)");

‎Exchange/DereTore.Exchange.Audio.HCA/Ath.cs

+5-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
1-
using DereTore.Common;
1+
using DereTore.Common;
22

33
namespace DereTore.Exchange.Audio.HCA {
44
internal sealed class Ath {
55

6+
static Ath() {
7+
}
8+
69
public bool Initialize(uint type, uint key) {
710
switch (type) {
811
case 0:
@@ -38,7 +41,7 @@ private void Init1(uint key) {
3841

3942
private readonly byte[] _table = new byte[0x80];
4043

41-
private static readonly byte[] AthInitList = new byte[] {
44+
private static readonly byte[] AthInitList = {
4245
0x78, 0x5f, 0x56, 0x51, 0x4e, 0x4c, 0x4b, 0x49, 0x48, 0x48, 0x47, 0x46, 0x46, 0x45, 0x45, 0x45,
4346
0x44, 0x44, 0x44, 0x44, 0x43, 0x43, 0x43, 0x43, 0x43, 0x43, 0x42, 0x42, 0x42, 0x42, 0x42, 0x42,
4447
0x42, 0x42, 0x41, 0x41, 0x41, 0x41, 0x41, 0x41, 0x41, 0x41, 0x41, 0x41, 0x40, 0x40, 0x40, 0x40,

‎Exchange/DereTore.Exchange.Audio.HCA/Channel.cs

+14-274
Original file line numberDiff line numberDiff line change
@@ -1,294 +1,34 @@
1-
using System;
1+
using System;
22
using System.Runtime.InteropServices;
3-
using DereTore.Common;
43

54
namespace DereTore.Exchange.Audio.HCA {
65
[StructLayout(LayoutKind.Sequential, Pack = 1)]
76
internal struct Channel {
87

9-
[MarshalAs(UnmanagedType.ByValArray, ArraySubType = UnmanagedType.R8, SizeConst = 0x80)]
8+
[MarshalAs(UnmanagedType.ByValArray, ArraySubType = UnmanagedType.R4, SizeConst = 0x80)]
109
public float[] Block;
11-
[MarshalAs(UnmanagedType.ByValArray, ArraySubType = UnmanagedType.R8, SizeConst = 0x80)]
10+
[MarshalAs(UnmanagedType.ByValArray, ArraySubType = UnmanagedType.R4, SizeConst = 0x80)]
1211
public float[] Base;
13-
[MarshalAs(UnmanagedType.ByValArray, ArraySubType = UnmanagedType.U1, SizeConst = 0x80)]
14-
public byte[] Value;
15-
[MarshalAs(UnmanagedType.ByValArray, ArraySubType = UnmanagedType.U1, SizeConst = 0x80)]
16-
public byte[] Scale;
17-
[MarshalAs(UnmanagedType.ByValArray, ArraySubType = UnmanagedType.U1, SizeConst = 8)]
18-
public byte[] Value2;
12+
[MarshalAs(UnmanagedType.ByValArray, ArraySubType = UnmanagedType.I1, SizeConst = 0x80)]
13+
public sbyte[] Value;
14+
[MarshalAs(UnmanagedType.ByValArray, ArraySubType = UnmanagedType.I1, SizeConst = 0x80)]
15+
public sbyte[] Scale;
16+
[MarshalAs(UnmanagedType.ByValArray, ArraySubType = UnmanagedType.I1, SizeConst = 8)]
17+
public sbyte[] Value2;
1918
[MarshalAs(UnmanagedType.I4)]
2019
public int Type;
2120
// Original type: public char *
21+
public IntPtr Value3;
2222
[MarshalAs(UnmanagedType.U4)]
23-
public uint Value3;
2423
public uint Count;
25-
[MarshalAs(UnmanagedType.ByValArray, ArraySubType = UnmanagedType.R8, SizeConst = 0x80)]
24+
[MarshalAs(UnmanagedType.ByValArray, ArraySubType = UnmanagedType.R4, SizeConst = 0x80)]
2625
public float[] Wav1;
27-
[MarshalAs(UnmanagedType.ByValArray, ArraySubType = UnmanagedType.R8, SizeConst = 0x80)]
26+
[MarshalAs(UnmanagedType.ByValArray, ArraySubType = UnmanagedType.R4, SizeConst = 0x80)]
2827
public float[] Wav2;
29-
[MarshalAs(UnmanagedType.ByValArray, ArraySubType = UnmanagedType.R8, SizeConst = 0x80)]
28+
[MarshalAs(UnmanagedType.ByValArray, ArraySubType = UnmanagedType.R4, SizeConst = 0x80)]
3029
public float[] Wav3;
31-
[MarshalAs(UnmanagedType.ByValArray, ArraySubType = UnmanagedType.R8, SizeConst = 8 * 0x80)]
30+
[MarshalAs(UnmanagedType.ByValArray, ArraySubType = UnmanagedType.R4, SizeConst = 8 * 0x80)]
3231
public float[] Wave;
3332

34-
public static Channel CreateDefault() {
35-
var v = default(Channel);
36-
v.Block = new float[0x80];
37-
v.Base = new float[0x80];
38-
v.Value = new byte[0x80];
39-
v.Scale = new byte[0x80];
40-
v.Value2 = new byte[8];
41-
v.Type = 0;
42-
v.Value3 = 0;
43-
v.Count = 0;
44-
v.Wav1 = new float[0x80];
45-
v.Wav2 = new float[0x80];
46-
v.Wav3 = new float[0x80];
47-
v.Wave = new float[8 * 0x80];
48-
return v;
49-
}
50-
51-
public void Decode1(DataBits data, uint a, int b, byte[] ath) {
52-
int v = data.GetBit(3);
53-
if (v >= 6) {
54-
for (uint i = 0; i < Count; ++i) {
55-
Value[i] = (byte)data.GetBit(6);
56-
}
57-
} else if (v != 0) {
58-
int v1 = data.GetBit(6);
59-
int v2 = (1 << v) - 1;
60-
int v3 = v2 >> 1;
61-
Value[0] = (byte)v1;
62-
for (uint i = 1; i < Count; ++i) {
63-
int v4 = data.GetBit(v);
64-
if (v4 != v2) {
65-
v1 += v4 - v3;
66-
} else {
67-
v1 = data.GetBit(6);
68-
}
69-
Value[i] = (byte)v1;
70-
}
71-
} else {
72-
Value.ZeroMem();
73-
}
74-
if (Type == 2) {
75-
v = data.CheckBit(4);
76-
Value2[0] = (byte)v;
77-
if (v < 15) {
78-
for (var i = 0; i < 8; ++i) {
79-
Value2[i] = (byte)data.GetBit(4);
80-
}
81-
}
82-
} else {
83-
for (uint i = 0; i < a; ++i) {
84-
//Value3[i] = (byte)data.GetBit(6);
85-
SetValue3(i, (byte)data.GetBit(6));
86-
}
87-
}
88-
for (uint i = 0; i < Count; ++i) {
89-
v = Value[i];
90-
if (v != 0) {
91-
v = (int)(ath[i] + ((b + i) >> 8) - ((v * 5) >> 1) + 1);
92-
if (v < 0) {
93-
v = 15;
94-
} else if (v >= 0x39) {
95-
v = 1;
96-
} else {
97-
v = ChannelTables.Decode1ScaleList[v];
98-
}
99-
}
100-
Scale[i] = (byte)v;
101-
}
102-
for (var i = Count; i < Scale.Length; ++i) {
103-
Scale[i] = 0;
104-
}
105-
for (uint i = 0; i < Count; ++i) {
106-
Base[i] = ChannelTables.Decode1ValueSingle[Value[i]] * ChannelTables.Decode1ScaleSingle[Scale[i]];
107-
}
108-
}
109-
110-
public void Decode2(DataBits data) {
111-
for (uint i = 0; i < Count; ++i) {
112-
float f;
113-
int s = Scale[i];
114-
int bitSize = ChannelTables.Decode2List1[s];
115-
int v = data.GetBit(bitSize);
116-
if (s < 8) {
117-
v += s << 4;
118-
data.AddBit(ChannelTables.Decode2List2[v] - bitSize);
119-
f = ChannelTables.Decode2List3[v];
120-
} else {
121-
v = (1 - ((v & 1) << 1)) * (v >> 1);
122-
if (v == 0) {
123-
data.AddBit(-1);
124-
}
125-
f = v;
126-
}
127-
Block[i] = Base[i] * f;
128-
}
129-
for (var i = Count; i < Block.Length; ++i) {
130-
Block[i] = 0;
131-
}
132-
}
133-
134-
public void Decode3(uint a, uint b, uint c, uint d) {
135-
if (Type != 2 && b != 0) {
136-
float[] listFloat = ChannelTables.Decode3ListSingle;
137-
int offset = ChannelTables.Decode3ListOffset;
138-
for (uint i = 0, k = c, l = c - 1; i < a; ++i) {
139-
for (uint j = 0; j < b && k < d; ++j, --l) {
140-
Block[k++] = listFloat[GetValue3(i) - Value[l] + offset] * Block[l];
141-
}
142-
}
143-
Block[0x80 - 1] = 0;
144-
}
145-
}
146-
147-
public static void Decode4(ref Channel @this, ref Channel next, int index, uint a, uint b, uint c) {
148-
if (@this.Type == 1 && c != 0) {
149-
var f1 = ChannelTables.Decode4ListSingle[next.Value2[index]];
150-
var f2 = f1 - 2f;
151-
float[] s = @this.Block;
152-
float[] d = next.Block;
153-
int sIndex, dIndex;
154-
sIndex = (int)b;
155-
dIndex = (int)b;
156-
for (uint i = 0; i < a; ++i) {
157-
// Don't know why, but it just happened.
158-
// See se_live_flic_perfect.hca
159-
// original:
160-
/*
161-
* (no 'break')
162-
* d[dIndex++] = s[sIndex] * f2;
163-
* s[sIndex++] = s[sIndex] * f1;
164-
*/
165-
if (sIndex >= s.Length || dIndex >= d.Length) {
166-
break;
167-
}
168-
d[dIndex] = s[sIndex] * f2;
169-
dIndex++;
170-
s[sIndex] = s[sIndex] * f1;
171-
sIndex++;
172-
}
173-
}
174-
}
175-
176-
public void Decode5(int index) {
177-
float[] s;
178-
float[] d;
179-
s = Block;
180-
d = Wav1;
181-
int sIndex = 0, dIndex = 0;
182-
int s1Index, s2Index;
183-
for (int i = 0, count1 = 1, count2 = 0x40; i < 7; ++i, count1 <<= 1, count2 >>= 1) {
184-
int dIndex1 = dIndex, dIndex2 = dIndex + count2;
185-
for (int j = 0; j < count1; ++j) {
186-
for (int k = 0; k < count2; ++k) {
187-
float a = s[sIndex++];
188-
float b = s[sIndex++];
189-
d[dIndex1++] = b + a;
190-
d[dIndex2++] = a - b;
191-
}
192-
dIndex1 += count2;
193-
dIndex2 += count2;
194-
}
195-
sIndex -= 0x80;
196-
HcaHelper.Exchange(ref sIndex, ref dIndex);
197-
HcaHelper.Exchange(ref s, ref d);
198-
}
199-
s = Wav1;
200-
d = Block;
201-
sIndex = dIndex = 0;
202-
for (int i = 0, count1 = 0x40, count2 = 1; i < 7; ++i, count1 >>= 1, count2 <<= 1) {
203-
// The original array is a 2-rank array, [7][0x40].
204-
int list1FloatIndex = i * 0x40;
205-
// The original array is a 2-rank array, [7][0x40].
206-
int list2FloatIndex = i * 0x40;
207-
s1Index = sIndex;
208-
s2Index = sIndex + count2;
209-
int dIndex1 = dIndex;
210-
int dIndex2 = dIndex + count2 * 2 - 1;
211-
for (int j = 0; j < count1; ++j) {
212-
for (int k = 0; k < count2; ++k) {
213-
float fa = s[s1Index++];
214-
float fb = s[s2Index++];
215-
float fc = ChannelTables.Decode5List1Single[list1FloatIndex++];
216-
float fd = ChannelTables.Decode5List2Single[list2FloatIndex++];
217-
d[dIndex1++] = fa * fc - fb * fd;
218-
d[dIndex2--] = fa * fd + fb * fc;
219-
}
220-
s1Index += count2;
221-
s2Index += count2;
222-
dIndex1 += count2;
223-
dIndex2 += count2 * 3;
224-
}
225-
HcaHelper.Exchange(ref sIndex, ref dIndex);
226-
HcaHelper.Exchange(ref s, ref d);
227-
}
228-
d = Wav2;
229-
for (int i = 0; i < 0x80; ++i) {
230-
d[i] = s[i];
231-
}
232-
s = ChannelTables.Decode5List3Single;
233-
sIndex = 0;
234-
d = Wave;
235-
// The original array is [8][0x80].
236-
dIndex = index * 0x80;
237-
float[] s1 = Wav2;
238-
s1Index = 0x40;
239-
float[] s2 = Wav3;
240-
s2Index = 0;
241-
for (int i = 0; i < 0x40; ++i) {
242-
d[dIndex++] = s1[s1Index++] * s[sIndex++] + s2[s2Index++];
243-
}
244-
for (int i = 0; i < 0x40; ++i) {
245-
d[dIndex++] = s[sIndex++] * s1[--s1Index] - s2[s2Index++];
246-
}
247-
s1 = Wav2;
248-
s2 = Wav3;
249-
s1Index = 0x40 - 1;
250-
s2Index = 0;
251-
for (int i = 0; i < 0x40; ++i) {
252-
s2[s2Index++] = s1[s1Index--] * s[--sIndex];
253-
}
254-
for (int i = 0; i < 0x40; ++i) {
255-
s2[s2Index++] = s[--sIndex] * s1[++s1Index];
256-
}
257-
}
258-
259-
private byte GetValue3(int refIndex) {
260-
int index = (int)(refIndex + Value3);
261-
if (0 <= index && index < 0x80) {
262-
return Value[index];
263-
} else if (0x80 <= index && index < 0x80 + 0x80) {
264-
return Scale[index - 0x80];
265-
} else {
266-
throw new ArgumentOutOfRangeException(nameof(refIndex));
267-
}
268-
}
269-
270-
private byte GetValue3(uint refIndex) {
271-
var index = refIndex + Value3;
272-
if (index < 0x80) {
273-
return Value[index];
274-
} else if (index < 0x80 + 0x80) {
275-
return Scale[index - 0x80];
276-
} else {
277-
throw new ArgumentOutOfRangeException(nameof(refIndex));
278-
}
279-
}
280-
281-
private void SetValue3(int refIndex, byte value) {
282-
Value[refIndex + Value3] = value;
283-
}
284-
285-
private void SetValue3(uint refIndex, byte value) {
286-
Value[refIndex + Value3] = value;
287-
}
288-
289-
private void SetValue3(byte value) {
290-
Value[Value3] = value;
291-
}
292-
29333
}
29434
}

0 commit comments

Comments
 (0)