Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destiny Bond not tracked #481

Open
quadraticmuffin opened this issue Jan 6, 2024 · 1 comment
Open

Destiny Bond not tracked #481

quadraticmuffin opened this issue Jan 6, 2024 · 1 comment

Comments

@quadraticmuffin
Copy link

When a Pokemon uses Destiny Bond, the message from showdown looks like the following:

|move|p1a: Qwilfish|Destiny Bond|p1a: Qwilfish
|-singlemove|p1a: Qwilfish|Destiny Bond

But the AbstractBattle class opts to ignore -singlemove messages, so it doesn't track the usage of Destiny Bond until it actually gets triggered and both Pokemon die, at which point it tracks a message like:

|
|t:|1704578006
|move|p2a: Arceus|Earth Power|p1a: Qwilfish
|-supereffective|p1a: Qwilfish
|-damage|p1a: Qwilfish|0 fnt
|faint|p1a: Qwilfish
|-activate|p1a: Qwilfish|move: Destiny Bond
|faint|p2a: Arceus
|
|upkeep

Surely any agent would find it useful to know when a pokemon has activated Destiny Bond, so that it can avoid KOing. Therefore I propose not to ignore -singlemove messages.

The other locations in Pokemon Showdown that use -singlemove are Glaive Rush, Grudge, and Rage.

@caymansimpson
Copy link
Contributor

I think this is fixed! #633

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants