Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to access Tide's Jar to attach session information? #1

Closed
phated opened this issue Jun 21, 2020 · 3 comments
Closed

Unable to access Tide's Jar to attach session information? #1

phated opened this issue Jun 21, 2020 · 3 comments

Comments

@phated
Copy link

phated commented Jun 21, 2020

I've been diving into session management in Tide. It seems like it is still a WIP but it sounded like this library is the direction things are moving towards.

I am noticing that Tide's cookie middleware hides the CookieJar from the consumer, so it can't be used with these traits. I'm not sure whether Tide should allow access to the CookieJar or if this should be changed to take a Request/Response pair instead of a CookieJar.

Any thoughts?

@jbr
Copy link
Member

jbr commented Jul 26, 2020

This was in fact the biggest challenge in implementing tide sessions with the old api. Closing this issue as it has now been addressed

@jbr jbr closed this as completed Jul 26, 2020
@phated
Copy link
Author

phated commented Jul 26, 2020

@jbr can you link where this was addressed? I'm trying to keep up on things but I didn't see this.

@jbr
Copy link
Member

jbr commented Jul 26, 2020

Check out #2 and http-rs/tide#646

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants