Remove #[allow(unused_mut)] (#231)

Remove #[allow(unused_mut)]

Author: fairingrey

examples/src/body_types.rs

@@ -11,28 +11,24 @@ struct Message {
     contents: String,
 }
 
-#[allow(unused_mut)] // Workaround clippy bug
 async fn echo_string(mut cx: Context<()>) -> String {
     let msg = cx.body_string().await.unwrap();
     println!("String: {}", msg);
     msg
 }
 
-#[allow(unused_mut)] // Workaround clippy bug
 async fn echo_bytes(mut cx: Context<()>) -> Vec<u8> {
     let msg = cx.body_bytes().await.unwrap();
     println!("Bytes: {:?}", msg);
     msg
 }
 
-#[allow(unused_mut)] // Workaround clippy bug
 async fn echo_json(mut cx: Context<()>) -> EndpointResult {
     let msg = cx.body_json().await.client_err()?;
     println!("JSON: {:?}", msg);
     Ok(response::json(msg))
 }
 
-#[allow(unused_mut)] // Workaround clippy bug
 async fn echo_form(mut cx: Context<()>) -> EndpointResult {
     let msg = cx.body_form().await?;
     println!("Form: {:?}", msg);

examples/src/cookies.rs

@@ -6,12 +6,10 @@ async fn retrieve_cookie(mut cx: Context<()>) -> String {
     format!("hello cookies: {:?}", cx.get_cookie("hello").unwrap())
 }
 
-#[allow(unused_mut)] // Workaround clippy bug
 async fn set_cookie(mut cx: Context<()>) {
     cx.set_cookie(Cookie::new("hello", "world")).unwrap();
 }
 
-#[allow(unused_mut)] // Workaround clippy bug
 async fn remove_cookie(mut cx: Context<()>) {
     cx.remove_cookie(Cookie::named("hello")).unwrap();
 }

examples/src/messages.rs

@@ -37,13 +37,11 @@ impl Database {
     }
 }
 
-#[allow(unused_mut)] // Workaround clippy bug
 async fn new_message(mut cx: Context<Database>) -> EndpointResult<String> {
     let msg = cx.body_json().await.client_err()?;
     Ok(cx.state().insert(msg).to_string())
 }
 
-#[allow(unused_mut)] // Workaround clippy bug
 async fn set_message(mut cx: Context<Database>) -> EndpointResult<()> {
     let msg = cx.body_json().await.client_err()?;
     let id = cx.param("id").client_err()?;

examples/src/multipart_form/mod.rs

@@ -9,7 +9,6 @@ struct Message {
     file: Option<String>,
 }
 
-#[allow(unused_mut)] // Workaround clippy bug
 async fn upload_file(mut cx: Context<()>) -> EndpointResult {
     // https://stackoverflow.com/questions/43424982/how-to-parse-multipart-forms-using-abonander-multipart-with-rocket
     let mut message = Message {

tide/src/middleware/cookies.rs

@@ -72,23 +72,19 @@ mod tests {
     static COOKIE_NAME: &str = "testCookie";
 
     /// Tide will use the the `Cookies`'s `Extract` implementation to build this parameter.
-    #[allow(unused_mut)] // Workaround clippy bug
     async fn retrieve_cookie(mut cx: Context<()>) -> String {
         format!("{}", cx.get_cookie(COOKIE_NAME).unwrap().unwrap().value())
     }
 
-    #[allow(unused_mut)] // Workaround clippy bug
     async fn set_cookie(mut cx: Context<()>) {
         cx.set_cookie(Cookie::new(COOKIE_NAME, "NewCookieValue"))
             .unwrap();
     }
 
-    #[allow(unused_mut)] // Workaround clippy bug
     async fn remove_cookie(mut cx: Context<()>) {
         cx.remove_cookie(Cookie::named(COOKIE_NAME)).unwrap();
     }
 
-    #[allow(unused_mut)] // Workaround clippy bug
     async fn set_multiple_cookie(mut cx: Context<()>) {
         cx.set_cookie(Cookie::new("C1", "V1")).unwrap();
         cx.set_cookie(Cookie::new("C2", "V2")).unwrap();