fix(cache): clear previous value only if flag is set

Author: smalluban

src/cache.js

@@ -44,7 +44,6 @@ export function get(target, key, getter) {
 
   if (entry.invalid === entry.state) {
     entry.state += 1;
-    entry.value = undefined;
   } else if (entry.checksum !== undefined && entry.checksum === calculateChecksum(entry)) {
     return entry.value;
   }
@@ -85,12 +84,16 @@ export function set(target, key, setter, value, callback) {
   }
 }
 
-export function invalidate(target, key) {
+export function invalidate(target, key, clearValue) {
   if (context) {
     context = null;
     throw Error(`[cache] Try to invalidate '${key}' in '${target}' during get invocation`);
   }
 
   const entry = getEntry(target, key);
+
   entry.invalid = entry.state;
+  if (clearValue) {
+    entry.value = undefined;
+  }
 }

src/define.js

@@ -69,7 +69,7 @@ if (process.env.NODE_ENV !== 'production') {
         node.disconnectedCallback();
 
         Object.keys(node.constructor.hybrids).forEach((key) => {
-          cache.invalidate(node, key);
+          cache.invalidate(node, key, true);
         });
 
         node.connectedCallback();

test/spec/define.js

@@ -1,4 +1,5 @@
 import define from '../../src/define';
+import { invalidate } from '../../src/cache';
 
 describe('define:', () => {
   it('should return custom element with a name', () => {
@@ -49,6 +50,13 @@ describe('define:', () => {
       expect(spy.calls.first().args[0]).toBe(el);
       expect(spy.calls.first().args[1]).toBe('one');
     }));
+
+    it('should return previus value when invalidate', () => tree((el) => {
+      el.one = 10;
+      expect(el.one).toBe(11);
+      invalidate(el, 'one');
+      expect(el.one).toBe(12);
+    }));
   });
 
   describe('for primitive value', () => {