Skip to content
This repository was archived by the owner on Mar 30, 2018. It is now read-only.

CertificateSpec doesn't include Organization and Country ... why not? #2168

Closed
christo4ferris opened this issue Jul 11, 2016 · 1 comment · Fixed by #2205
Closed

CertificateSpec doesn't include Organization and Country ... why not? #2168

christo4ferris opened this issue Jul 11, 2016 · 1 comment · Fixed by #2205

Comments

@christo4ferris
Copy link
Contributor

Description

in https://github.com/hyperledger/fabric/blob/master/membersrvc/ca/ca.go#L55
CertificateSpec doesn't include Organization and Country ... why not? There are accessor functions for these values that return the value from viper, which is inefficient to say the least.
https://github.com/hyperledger/fabric/blob/master/membersrvc/ca/ca.go#L164
https://github.com/hyperledger/fabric/blob/master/membersrvc/ca/ca.go#L170

Think that these values should be cached on initialization. Will yield a significant performance gain in creating certificates if we aren't reading the config twice for each certificate we create.

Describe How to Reproduce

read the code

@genggjh
Copy link
Contributor

genggjh commented Jul 12, 2016

I can cover this, pls assign to me.

@genggjh genggjh mentioned this issue Jul 14, 2016
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging a pull request may close this issue.

2 participants