Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish library interface #1000

Open
xermicus opened this issue Sep 1, 2022 · 1 comment
Open

Finish library interface #1000

xermicus opened this issue Sep 1, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@xermicus
Copy link
Contributor

xermicus commented Sep 1, 2022

Currently, Solang has a library interface, but it is only used for tests. In the long run we should be able to use our library interface as a the ground truth for all tests, the solang binary and anything else. Feel free to comment and collect ideas here regarding the direction we want to go with this interface.

@xermicus xermicus added the enhancement New feature or request label Sep 1, 2022
@seanyoung
Copy link
Contributor

  • The library interface is also used by the solang binary, but the library interface has far too many public items.
  • The library interface is also used by the language server, so it needs the entire ast exposed (but not codegen)
  • The solang binary may save intermediates like llvm ir, assembly of cfg. This interface could be much cleaner
  • The solana interface is extra ugly because currently Solana creates on binary for all contracts - this will soon change

Depends on #964 - once that is implemented, this will be much simpler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants