Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate code (part 3) #1263

Open
LucasSte opened this issue Apr 11, 2023 · 11 comments
Open

Duplicate code (part 3) #1263

LucasSte opened this issue Apr 11, 2023 · 11 comments
Labels
good first issue Good for newcomers

Comments

@LucasSte
Copy link
Contributor

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/emit/math.rs#L90-L107

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/emit/math.rs#L318-L335

===============================================

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/sema/expression/member_access.rs#L419-L427

https://github.com/hyperledger/solang/blob/c5e430461b9f9934d08afa2fc3b81962637c6c5d/src/sema/expression/member_access.rs#L431-L439

===============================================

https://github.com/hyperledger/solang/blob/1b46d73b32449a09ba1c1e54c8073ecb4d7cf4a0/src/sema/expression/mod.rs#L421-L437

https://github.com/hyperledger/solang/blob/1b46d73b32449a09ba1c1e54c8073ecb4d7cf4a0/src/sema/expression/mod.rs#L455-L471

===============================================

https://github.com/hyperledger/solang/blob/1b46d73b32449a09ba1c1e54c8073ecb4d7cf4a0/src/sema/expression/mod.rs#L484-L500

https://github.com/hyperledger/solang/blob/1b46d73b32449a09ba1c1e54c8073ecb4d7cf4a0/src/sema/expression/mod.rs#L620-L636

===============================================

https://github.com/hyperledger/solang/blob/1b46d73b32449a09ba1c1e54c8073ecb4d7cf4a0/src/sema/expression/mod.rs#L513-L543

https://github.com/hyperledger/solang/blob/1b46d73b32449a09ba1c1e54c8073ecb4d7cf4a0/src/sema/expression/mod.rs#L618-L648

===============================================

https://github.com/hyperledger/solang/blob/1b46d73b32449a09ba1c1e54c8073ecb4d7cf4a0/src/sema/expression/mod.rs#L583-L611

https://github.com/hyperledger/solang/blob/1b46d73b32449a09ba1c1e54c8073ecb4d7cf4a0/src/sema/expression/mod.rs#L654-L682

===============================================

https://github.com/hyperledger/solang/blob/1b46d73b32449a09ba1c1e54c8073ecb4d7cf4a0/src/sema/expression/mod.rs#L908-L934

https://github.com/hyperledger/solang/blob/1b46d73b32449a09ba1c1e54c8073ecb4d7cf4a0/src/sema/expression/mod.rs#L940-L966

https://github.com/hyperledger/solang/blob/1b46d73b32449a09ba1c1e54c8073ecb4d7cf4a0/src/sema/expression/mod.rs#L971-L997

https://github.com/hyperledger/solang/blob/1b46d73b32449a09ba1c1e54c8073ecb4d7cf4a0/src/sema/expression/mod.rs#L1050-L1076

===============================================
8.

https://github.com/hyperledger/solang/blob/1b46d73b32449a09ba1c1e54c8073ecb4d7cf4a0/src/codegen/mod.rs#L988-L1004

https://github.com/hyperledger/solang/blob/1b46d73b32449a09ba1c1e54c8073ecb4d7cf4a0/src/codegen/mod.rs#L1010-L1026

https://github.com/hyperledger/solang/blob/1b46d73b32449a09ba1c1e54c8073ecb4d7cf4a0/src/codegen/mod.rs#L1184-L1201

===============================================
9.

https://github.com/hyperledger/solang/blob/1b46d73b32449a09ba1c1e54c8073ecb4d7cf4a0/src/codegen/mod.rs#L1600-L1613

https://github.com/hyperledger/solang/blob/1b46d73b32449a09ba1c1e54c8073ecb4d7cf4a0/src/codegen/mod.rs#L1623-L1634

===============================================
10.

https://github.com/hyperledger/solang/blob/1b46d73b32449a09ba1c1e54c8073ecb4d7cf4a0/src/codegen/encoding/mod.rs#L370-L375

https://github.com/hyperledger/solang/blob/1b46d73b32449a09ba1c1e54c8073ecb4d7cf4a0/src/codegen/encoding/mod.rs#L501-L510

===============================================
11.
https://github.com/hyperledger/solang/blob/1b46d73b32449a09ba1c1e54c8073ecb4d7cf4a0/src/codegen/reaching_definitions.rs#L213-L219

https://github.com/hyperledger/solang/blob/1b46d73b32449a09ba1c1e54c8073ecb4d7cf4a0/src/codegen/vector_to_slice.rs#L155-L161

===============================================
12.

https://github.com/hyperledger/solang/blob/1b46d73b32449a09ba1c1e54c8073ecb4d7cf4a0/src/bin/solang.rs#L84-L99

https://github.com/hyperledger/solang/blob/1b46d73b32449a09ba1c1e54c8073ecb4d7cf4a0/src/bin/solang.rs#L231-L246

https://github.com/hyperledger/solang/blob/1b46d73b32449a09ba1c1e54c8073ecb4d7cf4a0/src/bin/solang.rs#L277-L292

===============================================
13.

https://github.com/hyperledger/solang/blob/1b46d73b32449a09ba1c1e54c8073ecb4d7cf4a0/src/bin/solang.rs#L129-L146

https://github.com/hyperledger/solang/blob/1b46d73b32449a09ba1c1e54c8073ecb4d7cf4a0/src/bin/solang.rs#L247-L264

https://github.com/hyperledger/solang/blob/1b46d73b32449a09ba1c1e54c8073ecb4d7cf4a0/src/bin/solang.rs#L293-L310

@LucasSte LucasSte added the good first issue Good for newcomers label Apr 14, 2023
@Celetert
Copy link

Hello! I am a beginner in FoSS ecosystem. I want to ask that wheather i should check issues those are not yet assigned only?

@xermicus
Copy link
Contributor

Hello! I am a beginner in FoSS ecosystem. I want to ask that wheather i should check issues those are not yet assigned only?

Yes, the general idea is that if someone is assigned to an issue, that issue is being worked on. If you spot a stale issue (e.g. the issue is assigned but there were no discussion and commits in a related PR happening for weeks), feel free to ping the assignee whether they are still working on it or not.

I can assign this issue here to you if you want?

@anj20
Copy link

anj20 commented May 5, 2023

@LucasSte can u assign this to me?

@LucasSte
Copy link
Contributor Author

@LucasSte can u assign this to me?

Done!

@LucasSte
Copy link
Contributor Author

@LucasSte can u assign this to me?

Hey @anj20, you were assigned to this issue two weeks ago, but we have not heard from you since then. Are you still interested in working on this?
If not, we better deassign you, so others can have the opportunity to contribute.

@anj20 anj20 removed their assignment May 27, 2023
@startup-dreamer
Copy link

I would like to work on this

@seanyoung
Copy link
Contributor

@startup-dreamer looking forward to seeing a pull request

@startup-dreamer
Copy link

I am little busy on personal project if anyone wants to take this he can, I will start work as soon as project is completed.

@startup-dreamer
Copy link

startup-dreamer commented Jun 14, 2023

whenever i run cargo test -p solang --test solana
error is thrown

     error: No suitable version of LLVM was found system-wide or pointed
              to by LLVM_SYS_150_PREFIX
              Consider using `llvmenv` to compile an appropriate copy of LLVM, and
              refer to the llvm-sys documentation for more information.

I have installed llvmenv (latest version) and set environmental variable LLVM_SYS_150_PREFIX as export LLVM_SYS_150_PREFIX=$(llvmenv prefix)
still it is not working any idea how to resolve this.

@seanyoung
Copy link
Contributor

@startup-dreamer please follow the instructions at https://solang.readthedocs.io/en/latest/installing.html#step-1-install-the-llvm-libraries and do a cargo clean

@startup-dreamer
Copy link

tried but error is persisting i don't think i will be able to resolve this issue sorry for the trouble

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants