Handle unpadded protected header in PackWireFormat::get_recipient_keys #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1324 +/- ##
=======================================
Coverage 95.43% 95.43%
=======================================
Files 476 476
Lines 28966 28966
=======================================
Hits 27645 27645
Misses 1321 1321 |
Signed-off-by: Andrew Whitehead <[email protected]>
andrewwhitehead
force-pushed
the
fix/get_pack_recip
branch
from
b22dd18 to
b82780f
Compare
|
@andrewwhitehead It work well with regards to #1323. Thanks! |
TimoGlastra
approved these changes
Jul 19, 2021
|
@TimoGlastra I think Indy-SDK must be padding the base64-encoded protected header, which seems to be counter to the JWE spec but is generally accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this only affects connection establishment when using an Askar wallet together with multi-tenant wallets.
Fixes #1323