-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor outbound queue interface #1348
Merged
andrewwhitehead
merged 6 commits into
openwallet-foundation:main
from
dbluhm:refactor/outbound-queue
Aug 16, 2021
Merged
Refactor outbound queue interface #1348
andrewwhitehead
merged 6 commits into
openwallet-foundation:main
from
dbluhm:refactor/outbound-queue
Aug 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Alternatively, I wonder if the redis implementation should live a little bit further distant from the ACA-Py core. Have we considered including a separate package in the repo for these sorts of plugins? |
Codecov Report
@@ Coverage Diff @@
## main #1348 +/- ##
==========================================
- Coverage 95.43% 95.41% -0.02%
==========================================
Files 476 476
Lines 28988 28962 -26
==========================================
- Hits 27664 27634 -30
- Misses 1324 1328 +4 |
burdettadam
reviewed
Aug 11, 2021
burdettadam
previously approved these changes
Aug 11, 2021
This value is not used but making this fix anyways for consistency Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
andrewwhitehead
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the outbound queue interface to be more easily generalized. As we've worked to implement outbound queuing via Kafka, we've found that the configuration just did not map onto what was needed in Kafka. Rather than expecting a connection string and parsing protocol etc. etc., this PR just passes all settings to the outbound queue implementation and allows it to read plugin configuration from the settings. This affords much greater flexibility in the structure of the outbound queue implementation. As a result, I removed some outbound queue command line arguments that were no longer used.
Additionally, I updated aioredis to 2.0.0. From the aioredis maintainers speaking on version 1.3.1 of the library:
I found that using aioredis 2.0.0 significantly simplified the code as it stood.
Some other minor consistency fixes were made to bring the outbound queue package in line with the rest of the code base.
I haven't had an opportunity to integration test the redis changes just yet. I noticed there were some tests for this but they did not appear to be run anywhere in the tests run by the github actions. Is this something we would want run as part of PR checks or is the occasional one-off sufficient?