feature/inbound-transport-profile #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Burdett <[email protected]>
Signed-off-by: Adam Burdett <[email protected]>
…t-profile root profile in inbound transport
Codecov Report
@@ Coverage Diff @@
## main #1407 +/- ##
=======================================
Coverage 95.31% 95.31%
=======================================
Files 482 482
Lines 29121 29123 +2
=======================================
+ Hits 27758 27760 +2
Misses 1363 1363 |
dbluhm
approved these changes
Sep 10, 2021
andrewwhitehead
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing a custom inbound transport there is no way to access settings through the profile. This PR adds a root profile to the
BaseInboundTransportclass that allows custom implemented inbound transports access to the profile provided toInboundTransportManager.main changes:
root_profileattribute.register_transport