Add support for custom offers from the proposal #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andraž Cuderman <[email protected]>
Signed-off-by: Andraž Cuderman <[email protected]>
acuderman
force-pushed
the
feat-IDENT-3499-json-ld-credential-offer-proposal-fix
branch
from
cd45b60 to
cf46cb9
Compare
acuderman
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1426 +/- ##
==========================================
- Coverage 95.30% 95.30% -0.01%
==========================================
Files 483 483
Lines 29237 29236 -1
==========================================
- Hits 27865 27864 -1
Misses 1372 1372 |
vidp1
approved these changes
Sep 29, 2021
andrewwhitehead
approved these changes
Sep 29, 2021
ctomc
deleted the
feat-IDENT-3499-json-ld-credential-offer-proposal-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Currently, the issuer only has the ability to offer a credential that is the same as the one defined in a credential proposal.
This PR enables the holder and issuer to negotiate about the credential via proposals and offers in order to agree on what credential the holder will receive.
Backwards compatibility:
If the counter-offer is not defined/empty logic stays the same as It was before this change.