Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation for range checks #1538

Merged
merged 4 commits into from
Dec 10, 2021
Merged

Fix validation for range checks #1538

merged 4 commits into from
Dec 10, 2021

Conversation

ianco
Copy link
Contributor

@ianco ianco commented Dec 7, 2021

Signed-off-by: Ian Costanzo [email protected]

ianco added 2 commits December 6, 2021 18:11
Signed-off-by: Ian Costanzo <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2021

Codecov Report

Merging #1538 (4046e68) into main (e59b377) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #1538      +/-   ##
==========================================
- Coverage   95.69%   95.69%   -0.01%     
==========================================
  Files         527      527              
  Lines       32393    32400       +7     
==========================================
+ Hits        30999    31005       +6     
- Misses       1394     1395       +1     

TimoGlastra
TimoGlastra previously approved these changes Dec 7, 2021
Signed-off-by: Ian Costanzo <[email protected]>
Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ianco ianco merged commit 7422b3c into openwallet-foundation:main Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants