platform target in run tests. #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Burdett <[email protected]>
|
Continues to work on Linux/Ubuntu on Intel processor, so that's good :-) |
|
See also #1689 |
|
We'll likely want similar changes in the |
andrewwhitehead
approved these changes
Mar 29, 2022
Codecov Report
@@ Coverage Diff @@
## main #1697 +/- ##
=======================================
Coverage 95.29% 95.29%
=======================================
Files 528 528
Lines 32878 32878
=======================================
Hits 31331 31331
Misses 1547 1547 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dbluhm suggested seeing if adding a platform target would allow docker to run the test scripts, which worked. I expect more changes for complete mac m1 development support but this seems to be a good starting point.
Signed-off-by: Adam Burdett [email protected]