feat: Add filter param to connection list for invitations #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in openwallet-foundation#1789, there is no way to currently filter for connections/invited created via the OOB handler. This commit adds a filter query param to filter off the invitation message ID. Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1797 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 530 530
Lines 33235 33236 +1
=======================================
+ Hits 31644 31645 +1
Misses 1591 1591 |
shaangill025
reviewed
Jun 8, 2022
| @@ -205,6 +205,11 @@ class ConnectionsListQueryStringSchema(OpenAPISchema): | |||
| ), | |||
| example=ConnRecord.Protocol.RFC_0160.aries_protocol, | |||
| ) | |||
| invitation_msg_id = fields.UUID( | |||
| description="Identifier of the associated Invintation Mesage", | |||
There was a problem hiding this comment.
Typo: Invitation Message
|
@frostyfrog I tested this and it is working. Based upon the description you provided in issue #1789, I think |
Signed-off-by: Colton Wolkins (Indicio work address) <[email protected]>
|
Yep! You're absolutely right. I just had it in draft because I wanted to make sure the black linting didn't error out on me before marking ready. |
shaangill025
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #1789, there is no way to currently filter for connections/invited created via the OOB handler. This commit adds a filter query parameter to filter with the invitation message ID.