Fix: Inbound Transport is_external attribute #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shaangill025 <[email protected]>
|
This is a redo of a previous PR. Please review. @shaangill025 -- let us know about the "Draft" status and when that is removed. Anxious to get this into the release. |
|
LGTM |
Signed-off-by: shaangill025 <[email protected]>
TheTechmage
approved these changes
Jun 14, 2022
There was a problem hiding this comment.
These changes look good to me. The only comment that I had was about adding a "Inbound/Outbound Transports" label right next to the "External Plugin" label, but the internal lists are going to typically be fairly small so I don't think it's necessary. Great work!
swcurran
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shaangill025 [email protected]
Closed original PR #1792 due to merge issues.