Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failed connectionless proof request on some case #1933

Merged
merged 1 commit into from
Sep 10, 2022

Conversation

kukgini
Copy link
Contributor

@kukgini kukgini commented Sep 8, 2022

In demo menu (2a) connectionless proof request, If a mobile agent (for instance Trinsic) does not include Accept header when calling proof request url, the demo would fail.

Signed-off-by: kukgini [email protected]

@kukgini kukgini changed the title fix: failed connectionless present proof on some case fix: failed connectionless proof request on some case Sep 8, 2022
@swcurran swcurran requested review from ianco and dbluhm September 8, 2022 16:57
@swcurran
Copy link
Contributor

swcurran commented Sep 8, 2022

@WadeBarnes -- can you look at the CircleCI error above -- "Could not find a usable config.yml, you may have revoked the CircleCI OAuth app."

ianco
ianco previously approved these changes Sep 8, 2022
@WadeBarnes
Copy link
Contributor

@WadeBarnes -- can you look at the CircleCI error above -- "Could not find a usable config.yml, you may have revoked the CircleCI OAuth app."

This looks like a very recent change to some config in GitHub. If you can see the list in this link; https://app.circleci.com/pipelines/github/hyperledger/aries-cloudagent-python. Run 4466 was the first occurrence triggered by this PR. Run 4467 triggered CircleCI just fine. Runs 4468 to 4471 were me attempting to redeliver the trigger from GitHub webhooks to CircleCI. @ryjones, the error indicates there may have been something revoked on the GitHub side. Know of anything? Based on the config in GitHub and CircleCI is should be using the deploy key you setup for it for it back in 2019.

@ryjones
Copy link
Member

ryjones commented Sep 8, 2022

I have no idea. I think it's because the PR is from outside of the main repo

@kukgini
Copy link
Contributor Author

kukgini commented Sep 9, 2022

I made this PR using the 'Edit this file' function on github. Could that help find the cause?

@swcurran
Copy link
Contributor

swcurran commented Sep 9, 2022

This PR is stuck without some solution to the Circle CI issue (which I don't understand :-( ). I think we need to be able to accept PRs that are submitted via the "Edit This File" capability -- it's very helpful in some situations.

@ryjones
Copy link
Member

ryjones commented Sep 9, 2022

@ianco I did this and it looks like things are working

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2022

Codecov Report

Merging #1933 (bf7b8bd) into main (4e5ed0f) will decrease coverage by 0.00%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main    #1933      +/-   ##
==========================================
- Coverage   93.59%   93.59%   -0.01%     
==========================================
  Files         539      539              
  Lines       34262    34270       +8     
==========================================
+ Hits        32069    32076       +7     
- Misses       2193     2194       +1     

@ryjones
Copy link
Member

ryjones commented Sep 9, 2022

@swcurran take a look?

@ryjones
Copy link
Member

ryjones commented Sep 10, 2022

@dbluhm

@ryjones ryjones requested a review from ianco September 10, 2022 00:13
In demo menu (2a) connectionless proof request, If a mobile agent (for instance Trinsic) does not include Accept header when present proof request, the demo would fail.

Signed-off-by: kukgini <[email protected]>
Signed-off-by: Ry Jones <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ryjones ryjones merged commit abcc96d into openwallet-foundation:main Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants