-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: failed connectionless proof request on some case #1933
Conversation
@WadeBarnes -- can you look at the CircleCI error above -- "Could not find a usable config.yml, you may have revoked the CircleCI OAuth app." |
This looks like a very recent change to some config in GitHub. If you can see the list in this link; https://app.circleci.com/pipelines/github/hyperledger/aries-cloudagent-python. Run 4466 was the first occurrence triggered by this PR. Run 4467 triggered CircleCI just fine. Runs 4468 to 4471 were me attempting to redeliver the trigger from GitHub webhooks to CircleCI. @ryjones, the error indicates there may have been something revoked on the GitHub side. Know of anything? Based on the config in GitHub and CircleCI is should be using the deploy key you setup for it for it back in 2019. |
I have no idea. I think it's because the PR is from outside of the main repo |
I made this PR using the 'Edit this file' function on github. Could that help find the cause? |
This PR is stuck without some solution to the Circle CI issue (which I don't understand :-( ). I think we need to be able to accept PRs that are submitted via the "Edit This File" capability -- it's very helpful in some situations. |
@ianco I did this and it looks like things are working |
Codecov Report
@@ Coverage Diff @@
## main #1933 +/- ##
==========================================
- Coverage 93.59% 93.59% -0.01%
==========================================
Files 539 539
Lines 34262 34270 +8
==========================================
+ Hits 32069 32076 +7
- Misses 2193 2194 +1 |
@swcurran take a look? |
In demo menu (2a) connectionless proof request, If a mobile agent (for instance Trinsic) does not include Accept header when present proof request, the demo would fail. Signed-off-by: kukgini <[email protected]> Signed-off-by: Ry Jones <[email protected]>
Kudos, SonarCloud Quality Gate passed!
|
In demo menu (2a) connectionless proof request, If a mobile agent (for instance Trinsic) does not include Accept header when calling proof request url, the demo would fail.
Signed-off-by: kukgini [email protected]