Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multitenant/mediation in demo #2075

Merged
merged 10 commits into from
May 27, 2023
Merged

Fix multitenant/mediation in demo #2075

merged 10 commits into from
May 27, 2023

Conversation

ianco
Copy link
Contributor

@ianco ianco commented Jan 10, 2023 •
edited
Loading

Signed-off-by: Ian Costanzo [email protected]

Tweaked the mediation code in the alice/faber demo (wasn't working properly).

Working with the fix from @usingtechnology in PR # 2232

@ianco ianco requested a review from TimoGlastra January 10, 2023 19:52
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dbluhm
Copy link
Contributor

dbluhm commented Jan 23, 2023

This is code I've touched recently. I'll try to squeeze in some time to take a look!

@ianco ianco mentioned this pull request Mar 14, 2023
Closed
@ianco ianco changed the title WIP fix multitenant/mediation in demo, now getting aca-py error Fix multitenant/mediation in demo, now getting aca-py error May 15, 2023
@ianco ianco marked this pull request as ready for review May 15, 2023 14:10
@ianco
Formatting
7aba579 
Signed-off-by: Ian Costanzo <[email protected]>
@ianco ianco requested review from dbluhm and usingtechnology May 15, 2023 14:11
usingtechnology
usingtechnology previously approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@usingtechnology usingtechnology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@usingtechnology usingtechnology mentioned this pull request May 15, 2023
Closed
@ianco ianco changed the title Fix multitenant/mediation in demo, now getting aca-py error Fix multitenant/mediation in demo May 16, 2023
@swcurran
Copy link
Contributor

Re-running the failed tests...

@swcurran
Copy link
Contributor

Tests still failing. @usingtechnology — could you please take a look?

@ianco
Copy link
Contributor Author

ianco commented May 17, 2023

Weird situation because Flake8 is failing in one of the libraries, not aca-py code :-(

@ianco
Copy link
Contributor Author

ianco commented May 17, 2023

Tests still failing. @usingtechnology — could you please take a look?

I took out a couple of code changes I made which don't seem to be doing anything and I don't recall why I made :-S

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dbluhm dbluhm merged commit d1ce07c into openwallet-foundation:main May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbluhm dbluhm dbluhm approved these changes

@usingtechnology usingtechnology usingtechnology left review comments

@TimoGlastra TimoGlastra Awaiting requested review from TimoGlastra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ianco @dbluhm @swcurran @usingtechnology