Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using YAML configuration file with run_docker #2091

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

matrixik
Copy link
Contributor

This will allow using scripts like this:

#!/usr/bin/env bash

# Uncomment for debugging
# set -o xtrace

set -eo pipefail  # Exit the script if any statement returns error.

SCRIPT_DIR="$( dirname "$(readlink -f "$0")" )"

export CONTAINER_NAME="aries_issuer"
export NETWORK_NAME="aries-mediator-service_mediator-network"
export PORTS="8002 11002"
export ARG_FILE="${SCRIPT_DIR}/cfg_issuer.yml"

../aries-cloudagent-python/scripts/run_docker start

I find working with yaml files easier/faster than very, very long command line when testing and debugging (because I can simply comment out some configs and uncomment others at the same time).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@swcurran
Copy link
Contributor

Can someone investigate and comment on the integration test failures? Solar flares?

@ianco
Copy link
Contributor

ianco commented Jan 25, 2023

Can someone investigate and comment on the integration test failures? Solar flares?

I'm guessing some kind of environment issue, I've restarted the integration tests to be sure.

There aren't any changes in this PR that should affect any of the tests

@ianco ianco merged commit dd57c2e into openwallet-foundation:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants