Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for JsonWebKey2020 for the connection invitations #2173

Conversation

dkulic
Copy link
Contributor

@dkulic dkulic commented Mar 21, 2023

Added support for the JsonWebKey2020 OKP keys for connection invitations.
To avoid extensive refactoring this is done by converting it to the supported base58 format.

Please, give feedback.

@dkulic dkulic force-pushed the connection_invitation_support_jwk branch from 3b09c9f to 995bb03 Compare March 21, 2023 09:39
Signed-off-by: Darko Kulic <[email protected]>
@dkulic dkulic force-pushed the connection_invitation_support_jwk branch from 15cf90c to 3474001 Compare March 29, 2023 13:15
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@swcurran
Copy link
Contributor

@andrewwhitehead — can you please review this? Thanks!

Copy link
Contributor

@dbluhm dbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swcurran swcurran merged commit d82e450 into openwallet-foundation:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants