Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to indy-credx 1.0 #2302

Merged
merged 5 commits into from
Jul 19, 2023

Conversation

andrewwhitehead
Copy link
Contributor

No description provided.

@andrewwhitehead andrewwhitehead force-pushed the upd/credx-0.4 branch 2 times, most recently from 8325a05 to 3105b32 Compare July 12, 2023 02:50
@andrewwhitehead andrewwhitehead changed the title Update to indy-credx 0.4 Update to indy-credx 1.0 Jul 12, 2023
dbluhm
dbluhm previously approved these changes Jul 12, 2023
@swcurran
Copy link
Contributor

@andrewwhitehead — can you please address the conflict.

Signed-off-by: Andrew Whitehead <[email protected]>
dbluhm
dbluhm previously approved these changes Jul 12, 2023
@andrewwhitehead
Copy link
Contributor Author

The --refuse-legacy-revocation flag could still use some testing, I'm looking at that now.

@swcurran swcurran marked this pull request as draft July 12, 2023 16:49
andrewwhitehead and others added 2 commits July 12, 2023 15:04

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@swcurran
Copy link
Contributor

@andrewwhitehead -- are you able to update this? Status on what's keeping it in Draft state?

Thanks!

@dbluhm
Copy link
Contributor

dbluhm commented Jul 18, 2023

I put together a quick test setup to validate these changes and I think it looks like everything is working. My setup has an "Alice" and a "Bob" agent:

  • Alice is acting as an issuer and verifier
  • Bob is a holder and prover
  • Alice is running on an image built from this branch
  • Bob is running on 0.8.2
  • Alice has --anoncreds-legacy-revocation=reject

In my scenario:

  • Alice goes through credential issuance setup (TAA, public DID, schema, cred def, rev reg, etc.)
  • Alice issues a credential to Bob
  • Alice requests presentation from Bob without non_revoked; verified as true, not sure what to actually expect here
  • Alice revokes the credential
  • Alice requests presentation from Bob with non_revoked after revocation; verified as false, would normally verify as false but expected false anyways because of --anoncreds-legacy-revocation=reject
  • Alice requests presentation from Bob with non_revoked before revocation; verified as false, would normally verify as true, expected false because of --anoncreds-legacy-revocation=reject

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dbluhm
Copy link
Contributor

dbluhm commented Jul 18, 2023

I'll run some more tests to hit the other cases:

  • accepts old when set to accept
  • accepts new when set to reject

@dbluhm
Copy link
Contributor

dbluhm commented Jul 18, 2023

Checked and passing:

Accepts old when set to accept

  • Bob is running on 0.8.2
  • Alice has --anoncreds-legacy-revocation=accept
  • Alice requests presentation from Bob without non_revoked; verified as true
  • Alice requests presentation from Bob with non_revoked after revocation; verified as false, expected false
  • Alice requests presentation from Bob with non_revoked before revocation; verified as true, expected true because of --anoncreds-legacy-revocation=accept

Accepts new when set to reject

  • Bob is running on image built from this branch
  • Alice has --anoncreds-legacy-revocation=reject
  • Alice requests presentation from Bob without non_revoked; verified as true
  • Alice requests presentation from Bob with non_revoked after revocation; verified as false, expected false
  • Alice requests presentation from Bob with non_revoked before revocation; verified as true, expected true because bob is running new code so --anoncreds-legacy-revocation=reject didn't apply

@andrewwhitehead
Copy link
Contributor Author

I think this is ready then, but I'm currently getting a server error when trying to move it out of draft.

@dbluhm dbluhm marked this pull request as ready for review July 19, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants