Upgrade pre-commit and flake8 dependencies; fix flake8 warnings #2399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
…e `is` / `is not`, for instance checks use `isinstance()`" Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
pytest-flake8 is unmaintained and does not support flake8 > 5.0 Signed-off-by: ff137 <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
@swcurran I just noticed that the |
|
I don’t think anything changed — all of the BCovrin tests are running again now that the ledger has been reset. Definitely, we need to discuss what tests are required — tomorrow’s ACA-Pug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: flake8 must remain pinned to v4.0 as pytest-flake8 is unmaintained and doesn't support flake8 > 5.0 (latest = 6.1)
I propose migrating to ruff and pytest-ruff. Created issue: #2400
Upgrades
.pre-commit-config.yamlto use latest versions for pre-commit-hook, black, and flake8.This fixes pre-commit not being in sync with black/flake8 enforcement in the github actions.
Additionally we upgrade flake8, flake8-docstrings, and pydocstyle to latest.
Includes fixes for all flake8 warnings in ./aries_cloudagent, because if PR tests enforces flake8, then the existing code should abide by it too :-)
The remaining flake8 warnings are primarily for missing docstrings in ./demo