Issue #2419 InvalidClientTaaAcceptanceError time too precise error if container timezone is not UTC #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Looks like there's some minor formatting checks failing. Can you check it out? |
|
@andrewwhitehead this seems like a reasonable change but interested in your thoughts to see if there's any implications I'm missing. |
Ennovate-com
force-pushed
the
bugfix/time-too-precise
branch
from
75d24c5 to
94680bf
Compare
|
@dbluhm Andrew Whitehead commented on the Indy VDR equivalent PR#210. |
dbluhm
approved these changes
Sep 14, 2023
Signed-off-by: Rob Simpson <[email protected]>
dbluhm
force-pushed
the
bugfix/time-too-precise
branch
from
8e048da to
d9208dc
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds timezone.utc to datetime.combine to ensure time will be midnight in UTC regardless of the default timezone