Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update devcontainer documentation #2729

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Update devcontainer documentation #2729

merged 2 commits into from
Jan 23, 2024

Conversation

jamshale
Copy link
Contributor

@jamshale jamshale commented Jan 19, 2024 •
edited
Loading

Most of the documentation was pretty good but I tried to make it more obvious that this is a good option.

  • I added more configurations to make it more obvious you can deploy multiple agent debug sessions.
  • You don't actually need to expose ports to access the admin api so I removed that stuff.
  • If you run your von-network and tails server from inside the dev container you can use local host and all the webhooks work as well.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jamshale jamshale marked this pull request as ready for review January 22, 2024 17:32
@jamshale jamshale merged commit 5a8748e into openwallet-foundation:main Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swcurran swcurran swcurran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamshale @swcurran