-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality for building and running agents seprately #2845
Add functionality for building and running agents seprately #2845
Conversation
Signed-off-by: Sarthak Vijayvergiya <[email protected]>
I’m not clear on what you mean by the “resolution” functionality. I can see the separation of build and run — is that what you mean? |
Yes, the separation of "build" and "run" refers to different functionalities in the script. Specifically, "build" is responsible for building the Docker image of the agent, while "run" executes the agent within a Docker container. In the "run" functionality, we also mount volumes from the host into the Docker container. This allows for a more streamlined development and debugging process, as we don't need to rebuild the Docker images repeatedly. Additionally, the script supports a default behavior: if neither "build" nor "run" is specified, it defaults to both building and running the agent. |
Got it — sounds good. Thanks! |
Looks good! Can you add a comment to the docs (maybe here: https://github.com/hyperledger/aries-cloudagent-python/blob/main/docs/demo/README.md#other-environment-settings) describing this? Maybe mention that this can support auto-reloading of code so you don't have to repeatedly restart the demo while developing ... |
Signed-off-by: Sarthak Vijayvergiya <[email protected]>
perfect, I have updated the docs. |
Hi @sarthakvijayvergiya , ran a quick test and it looks good. Just to be clear - when I ran the demo and edited the code, the demo didn't auto-reload. I stopped and restarted the agent (didn't have to rebuild the container) and it picked up the changes. So it's a more efficient process for sure, but should it auto-reload without restarting? |
You're absolutely right. I haven't implemented auto-reloading. The aim was simply to reduce the need for repetitive container builds. Adding auto-reloading would indeed be a valuable feature, but it's currently outside the scope of this request. However, I'm more than happy to tackle it in a separate request if that's something we'd like to explore further. |
Signed-off-by: Sarthak Vijayvergiya <[email protected]>
0864618
to
5b32130
Compare
|
Build
./demo/run_demo build alice --wallet-type askar-anoncreds --events
Run
./demo/run_demo run alice --wallet-type askar-anoncreds --events