[BUG] Handle get key operation when no tag has been set #3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick St-Louis <[email protected]>
Signed-off-by: Patrick St-Louis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
jamshale
reviewed
Sep 26, 2024
|
another fix could be to change this line: from: if kid:
tags = {"kid": kid}
else:
tags = Noneto if kid:
tags = {"kid": kid}
else:
tags = {}I believe this would be more consistent as a fix since all keys will have a tags object. Any opinion? |
Signed-off-by: PatStLouis <[email protected]>
Signed-off-by: PatStLouis <[email protected]>
|
I made a combination of @jamshale suggestion and the latter idea. |
Signed-off-by: PatStLouis <[email protected]>
|
jamshale
approved these changes
Sep 26, 2024
ff137
pushed a commit
to ff137/acapy
that referenced
this pull request
Oct 22, 2024
…oundation#3256) * Bug-fix Signed-off-by: Patrick St-Louis <[email protected]> * Update in_memory.py Signed-off-by: Patrick St-Louis <[email protected]> * linting Signed-off-by: PatStLouis <[email protected]> * apply better suggestion Signed-off-by: PatStLouis <[email protected]> * set empty tags object instead of none for consistency Signed-off-by: PatStLouis <[email protected]> * remove unnecessary change in the in memory wallet Signed-off-by: PatStLouis <[email protected]> --------- Signed-off-by: Patrick St-Louis <[email protected]> Signed-off-by: PatStLouis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle cases where a key doesn't have a tags property.
@dbluhm @jamshale small but critical bug introduced by my last PR, I was under the impression every key had tags by default but it doesn't seem like so, this will handle such cases.