-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update revocation demo #644
Update revocation demo #644
Conversation
Signed-off-by: Nicholas Rempel <[email protected]>
Signed-off-by: Nicholas Rempel <[email protected]>
Signed-off-by: Nicholas Rempel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #644 +/- ##
=======================================
Coverage 98.70% 98.70%
=======================================
Files 250 250
Lines 13385 13385
=======================================
Hits 13211 13211
Misses 174 174 |
Signed-off-by: Nicholas Rempel <[email protected]>
This pull request introduces 2 alerts when merging c286654 into 31f1c87 - view on LGTM.com new alerts:
|
Is
|
Signed-off-by: Ian Costanzo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- see pr on the ngrok-wait.sh script
- when starting faber with --revocation make sure tails url is supplied
Fix location of jq in script
This pull request introduces 2 alerts when merging 96a9c9b into 31f1c87 - view on LGTM.com new alerts:
|
Signed-off-by: Nicholas Rempel <[email protected]>
Signed-off-by: Nicholas Rempel <[email protected]>
Up to @ianco to approve as it's waiting on his changes requested |
Signed-off-by: Nicholas Rempel <[email protected]>
Update revocation demo to support old tails server environment variable for backwards compatibility and documentation alignment