Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperstack.send_message needs timeout #144

Closed
catmando opened this issue Mar 25, 2019 · 0 comments
Closed

Hyperstack.send_message needs timeout #144

catmando opened this issue Mar 25, 2019 · 0 comments
Labels
enhancement New feature or request ready-to-release Internal Use Only: Has been fixed, specs passing and pushed to edge branch
Milestone

Comments

@catmando
Copy link
Contributor

catmando commented Mar 25, 2019

Hyperstack.send_to_server will cleanly drop messages on the floor if the server is not up, but relies on getting back an HTTP error code (i.e. 504). There are cases that due to setup problems with the server unrelated to Hyperstack, the request to the server may simply hang.

This causes Hyperstack.send_to_server to propagate a timeout error back up the system, which crashes the whole console (for example.)

This makes debugging the unrelated server problem difficult.

What we need to do is wrap send_to_server in a configurable timeout that will cleanly drop the message.

While we are at it, setting the configurable timeout to a negative value should simply drop the value, while 0 and nil should ignore the time out.

@catmando catmando added the enhancement New feature or request label Mar 25, 2019
@catmando catmando added this to the alpha1.5 milestone Mar 25, 2019
@catmando catmando added the ready-to-release Internal Use Only: Has been fixed, specs passing and pushed to edge branch label Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready-to-release Internal Use Only: Has been fixed, specs passing and pushed to edge branch
Projects
None yet
Development

No branches or pull requests

1 participant