Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

component class .to_n broken #153

Closed
catmando opened this issue Apr 5, 2019 · 1 comment
Closed

component class .to_n broken #153

catmando opened this issue Apr 5, 2019 · 1 comment
Labels
bug Something isn't working ready-to-release Internal Use Only: Has been fixed, specs passing and pushed to edge branch
Milestone

Comments

@catmando
Copy link
Contributor

catmando commented Apr 5, 2019

should be:

module Hyperstack
  module Internal
    module Component
      module ClassMethods
        def to_n
          Hyperstack::Internal::Component::ReactWrapper.create_native_react_class(self)
        end
      end
    end
  end
end

work around is to apply to above patch, or even easier:

add

  def self.to_n
    Hyperstack::Internal::Component::ReactWrapper.create_native_react_class(self)
  end

In your HyperComponent base class

@catmando catmando added the bug Something isn't working label Apr 5, 2019
@catmando catmando added this to the alpha1.4 milestone Apr 5, 2019
@catmando catmando modified the milestones: alpha1.4, alpha1.5 Apr 18, 2019
@catmando
Copy link
Contributor Author

closed in 01f0d20

@catmando catmando added the ready-to-release Internal Use Only: Has been fixed, specs passing and pushed to edge branch label Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready-to-release Internal Use Only: Has been fixed, specs passing and pushed to edge branch
Projects
None yet
Development

No branches or pull requests

1 participant