Skip to content
This repository was archived by the owner on Oct 16, 2021. It is now read-only.

Commit 97e68d8

Browse files
stefanmbBethGriggs
authored andcommitted
build: cherry pick V8 change for windows DLL support
Ref: nodejs/node#9385 PR-URL: nodejs/node#8084 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 48e4201 commit 97e68d8

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

deps/v8z/build/toolchain.gypi

+4-3
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
'ubsan_vptr%': 0,
4040
'v8_target_arch%': '<(target_arch)',
4141
'v8_host_byteorder%': '<!(python -c "import sys; print sys.byteorder")',
42+
'force_dynamic_crt%': 0,
4243
# Native Client builds currently use the V8 ARM JIT and
4344
# arm/simulator-arm.cc to defer the significant effort required
4445
# for NaCl JIT support. The nacl_target_arch variable provides
@@ -1028,7 +1029,7 @@
10281029
'VCCLCompilerTool': {
10291030
'Optimization': '0',
10301031
'conditions': [
1031-
['component=="shared_library"', {
1032+
['component=="shared_library" or force_dynamic_crt==1', {
10321033
'RuntimeLibrary': '3', # /MDd
10331034
}, {
10341035
'RuntimeLibrary': '1', # /MTd
@@ -1080,7 +1081,7 @@
10801081
'StringPooling': 'true',
10811082
'BasicRuntimeChecks': '0',
10821083
'conditions': [
1083-
['component=="shared_library"', {
1084+
['component=="shared_library" or force_dynamic_crt==1', {
10841085
'RuntimeLibrary': '3', #/MDd
10851086
}, {
10861087
'RuntimeLibrary': '1', #/MTd
@@ -1268,7 +1269,7 @@
12681269
'FavorSizeOrSpeed': '0',
12691270
'StringPooling': 'true',
12701271
'conditions': [
1271-
['component=="shared_library"', {
1272+
['component=="shared_library" or force_dynamic_crt==1', {
12721273
'RuntimeLibrary': '2', #/MD
12731274
}, {
12741275
'RuntimeLibrary': '0', #/MT

deps/v8z/include/v8-version.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#define V8_MAJOR_VERSION 4
1212
#define V8_MINOR_VERSION 5
1313
#define V8_BUILD_NUMBER 103
14-
#define V8_PATCH_LEVEL 42
14+
#define V8_PATCH_LEVEL 43
1515

1616
// Use 1 for candidates and 0 otherwise.
1717
// (Boolean macro values are not supported by all preprocessors.)

0 commit comments

Comments
 (0)