lib: better regexp escape

Author: indutny

Diff for: lib/caine/contributing.js

@@ -210,10 +210,15 @@ Contributing.prototype.parseQuestion = function parseQuestion(text) {
   if (match !== null) {
     if (/one/i.test(match[1])) {
       var oneof = match[2].split(/\s*,\s*/g);
-      expected = new RegExp('^\\s*(' + oneof.join('|') + ')\\s*$', 'i');
+
+      var subre = oneof.map(function(part) {
+        return part.replace(/([^\w\d_])/g, '\\$1');
+      }).join('|');
+      expected = new RegExp('^\\s*(' + subre + ')\\s*$', 'i');
       reason = 'Expected one of: `' + oneof.join('`, `') + '`, but got: `@1`';
     } else {
-      expected = new RegExp('^\\s*(' + match[2] + ')\\s*$', 'i');
+      var subre = match[2].replace(/([^\w\d_])/g, '\\$1');
+      expected = new RegExp('^\\s*(' + subre + ')\\s*$', 'i');
       reason = 'Expected: `' + match[2] + '`, but got: `@1`';
     }
   }

Diff for: test/contributing-test.js

@@ -118,7 +118,8 @@ describe('Contributing', function() {
                    'Expected: `yes`, but got: `wait, what`');
       assert.equal(res.results[1].reason,
                    'Expected one of: `tls`, `crypto`, `buffer`, `http`, ' +
-                       '`https`, `assert`, `util`, `streams`, `other`, ' +
+                       '`https`, `assert`, `util`, `streams`, `smalloc`, ' +
+                       '`cluster`, `child_process`, `dgram`, `c++`, `other`, ' +
                        'but got: `everything`');
       assert.equal(res.results[2].reason,
                    'Expected one of: `v0.10`, `v0.12`, `v1.0.0`, ' +

Diff for: test/fixtures/CONTRIBUTING.md

@@ -446,7 +446,7 @@ core team members?
   likely not a io.js problem. _Expected: `yes`_
 * Which part of core do you think it might be related to?
   _One of: `tls, crypto, buffer, http, https, assert, util, streams,
-  other`_ (_label_)
+  smalloc, cluster, child_process, dgram, c++, other`_ (_label_)
 * Which versions of io.js do you think are affected by this?
   _One of: `v0.10, v0.12, v1.0.0`_ (_label_)
 * _PR-only_ Does `make test` pass after applying this Pull Request.
@@ -474,7 +474,6 @@ Caine.
 
 ### Responsibilities
 
-* indutny: crypto
-* trevnorris: buffer
-* isaacs: streams
-* bnoordhuis: other
+* indutny: crypto, tls, https, child_process, c++
+* trevnorris: buffer, http, https, smalloc
+* bnoordhuis: http, cluster, child_process, dgram