Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Enable point batching by default #138

Closed
jackzampolin opened this issue Dec 15, 2015 · 7 comments
Closed

[Request] Enable point batching by default #138

jackzampolin opened this issue Dec 15, 2015 · 7 comments

Comments

@jackzampolin
Copy link

InfluxDB is significantly more performant when points are written in batches. Making the default behavior of the client point batching should help increase performance for people unfamiliar with InfluxDB.

@majst01, Please consider making the following setting enabled by default:

# Enabled by default
influxDB.enableBatch(2000, 100, TimeUnit.MILLISECONDS);

# Disable batching
influxDB.disableBatching();

# Change batching config
influxDB.configureBatching(10000, 200, TimeUnit.MILLISECONDS);
@majst01
Copy link
Collaborator

majst01 commented Nov 7, 2016

We will leave the decision to the developer, as he understands exactly how to act on the data.

@majst01 majst01 closed this as completed Nov 7, 2016
@jackzampolin jackzampolin reopened this Nov 7, 2016
@jackzampolin
Copy link
Author

jackzampolin commented Nov 7, 2016

Writing many small requests is a common performance issue that new users run into. Enabling batching by default will eliminate these issues for new users. Please reconsider changing the defaults.

@majst01
Copy link
Collaborator

majst01 commented Nov 7, 2016

And what should be sensible defaults for amount, time, and so forth

@jackzampolin
Copy link
Author

I think the following would be sensible defaults.

pointsPerBatch: 2000
batchTime: 1s

@majst01
Copy link
Collaborator

majst01 commented Nov 8, 2016

Ok, but if someone wants different settings, what would be the workflow ? stop the already running batchprocessor and create a new one with the desired settings.
Im still against this idea

@jiafu1115
Copy link
Contributor

jiafu1115 commented Nov 10, 2016

@jackzampolin agree with @majst01, every developer should set their batch parameter. if provide batch used hard code parameters, it may cause issue not easy to be found. So I also think this issue should be closed. WDTY?

@majst01
Copy link
Collaborator

majst01 commented Nov 10, 2016

As i already said, this is the wrong idea.

@majst01 majst01 closed this as completed Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants