-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async response #386
Comments
Nice to see the integration into zipkin ! |
Please do @majst01 I am not a java dev and I am doing my best to look like one! :D |
I have not spare time actually to invest a lot into this library, sorry. |
@ivankudibal -- is this something your team can work on? |
@gianarb -- Do you have batching enabled ? When you do so, influxdb client will collect the data points into a buffer and it will flush it automatically in a separate thread when certain properties of the entries in the buffer will be met (count, age). For queries there are methods that are asynchronous: InfluxDb.java: |
@gianarb I added some comments directly to the mentioned zipkin PR. |
I didn't know about this method. I will have a look. Thanks
We spoke about batch writing but it's something that zipkin can manage by itself and I am not sure if having 2 resource managers will be good. At the moment we decided to avoid baching. Thanks @fmachado !! |
Hello!
I am working on integration between Zipkin and InfluxDB with @goller these days.
At the moment we are using this library. We would like to have back the async response other than the sync one as it happens now.
You can see why here in this comment
openzipkin/zipkin#1781 (comment)
What do you think about exposing this capability maybe creating a sync and async adapter in the client itself?
Thanks a lot
The text was updated successfully, but these errors were encountered: