Skip to content

Commit 6c372ec

Browse files
committed
[Tests] require ASSERT tests to pass
- Skip one, pending nodejs/node#30743
1 parent a42223e commit 6c372ec

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

.travis.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ matrix:
1414
- node_js: "12"
1515
env: ASSERT=true TEST=true
1616
- node_js: "10"
17-
env: ASSERT=true TEST=true
17+
env: ASSERT=true TEST=true ALLOW_FAILURE=true
1818
allow_failures:
1919
- env: COVERAGE=true
20-
- env: ASSERT=true TEST=true # some failures are node bugs, some are deep-equal v2 blockers

test/cmp.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,6 @@ test('arrays initiated', function (t) {
203203
t.end();
204204
});
205205

206-
// eslint-disable-next-line max-statements
207206
test('arrays assigned', function (t) {
208207
var a0 = [
209208
undefined,
@@ -239,7 +238,6 @@ test('arrays assigned', function (t) {
239238
t.end();
240239
});
241240

242-
// eslint-disable-next-line max-statements
243241
test('arrays push', function (t) {
244242
var a0 = [
245243
undefined,
@@ -505,8 +503,9 @@ test('getters', { skip: !Object.defineProperty }, function (t) {
505503
t.end();
506504
});
507505

506+
var isAssertAndNode1321 = process.env.ASSERT && process.version.replace(/^v/g, '').replace(/[^.]+(?:.)?/g, function (x, i) { return x * Math.pow(10, i); }) <= '1320000';
508507
// eslint-disable-next-line no-proto
509-
test('fake arrays: extra keys will be tested', { skip: [].__proto__ !== Array.prototype }, function (t) {
508+
test('fake arrays: extra keys will be tested', { skip: [].__proto__ !== Array.prototype || isAssertAndNode1321 }, function (t) {
510509
var a = {
511510
__proto__: Array.prototype,
512511
0: 1,

0 commit comments

Comments
 (0)