Skip to content
This repository was archived by the owner on Feb 27, 2024. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jenkins-x/jenkins-x-boot-config
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: introproventures/jenkins-x-boot-config
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Can’t automatically merge. Don’t worry, you can still create the pull request.
  • 10 commits
  • 20 files changed
  • 6 contributors

Commits on May 19, 2020

  1. fix: Update Lighthouse-related configuration

    Signed-off-by: Andrew Bayer <[email protected]>
    abayer authored and igdianov committed May 19, 2020
    Copy the full SHA
    a9d3222 View commit details
  2. chore: Switch boot-vault to lighthouse

    Signed-off-by: Andrew Bayer <[email protected]>
    abayer authored and igdianov committed May 19, 2020
    Copy the full SHA
    f5a18f2 View commit details
  3. chore: Switch to Lighthouse as default

    Signed-off-by: Andrew Bayer <[email protected]>
    abayer authored and igdianov committed May 19, 2020
    Copy the full SHA
    4961f50 View commit details
  4. Use the correct kaniko credsStore

    I know because I changed it in GoogleContainerTools/kaniko#1121 :)
    carlossg authored and igdianov committed May 19, 2020
    Copy the full SHA
    ee4cedf View commit details
  5. fix: making sure that custom, non default Docker registry can be used…

    … on EKS and GKE
    
    Fixes jx-7148
    hferentschik authored and igdianov committed May 19, 2020
    Copy the full SHA
    43c6ce5 View commit details
  6. feat: configure boot for Openshift with restricted permissions

    feat: check the key exists before getting its value
    
    feat: pass the strictPermissions flag to jxboot-resources
    Daniel Gozalo authored and igdianov committed May 19, 2020
    Copy the full SHA
    91cfa33 View commit details
  7. fix: Copy jx dependencies into temp JX_HOME

    Signed-off-by: Andrew Bayer <[email protected]>
    abayer authored and igdianov committed May 19, 2020
    Copy the full SHA
    115ba53 View commit details
  8. Copy the full SHA
    76ddce8 View commit details
  9. Copy the full SHA
    38de9da View commit details
  10. Copy the full SHA
    ebdd9f1 View commit details
2 changes: 2 additions & 0 deletions bdd/bdd.sh
Original file line number Diff line number Diff line change
@@ -24,6 +24,8 @@ export XDG_CONFIG_HOME=$JX_HOME

mkdir -p $JX_HOME/git

jx install dependencies --all

jx --version

# replace the credentials file with a single user entry
2 changes: 1 addition & 1 deletion bdd/boot-local/jx-requirements.yml
Original file line number Diff line number Diff line change
@@ -36,4 +36,4 @@ storage:
versionStream:
ref: "master"
url: https://github.com/jenkins-x/jenkins-x-versions.git
webhook: prow
webhook: lighthouse
2 changes: 1 addition & 1 deletion bdd/boot-vault/jx-requirements.yml
Original file line number Diff line number Diff line change
@@ -39,4 +39,4 @@ versionStream:
url: https://github.com/jenkins-x/jenkins-x-versions.git
vault:
disableURLDiscovery: true
webhook: prow
webhook: lighthouse
49 changes: 49 additions & 0 deletions env/jenkins-x-platform/values.tmpl.yaml
Original file line number Diff line number Diff line change
@@ -181,6 +181,43 @@ controllerbuild:
- "--verbose"
{{- end }}

{{- if hasKey .Requirements.cluster "strictPermissions" }}
{{- if and (eq .Requirements.cluster.provider "openshift") (.Requirements.cluster.strictPermissions) }}
gcpreviews:
clusterrole:
enabled: false

postinstalljob:
clusterrole:
enabled: false

controllerworkflow:
clusterrole:
enabled: false

controllerbuild:
clusterrole:
enabled: false

controllercommitstatus:
clusterrole:
enabled: false

controllerrole:
clusterrole:
enabled: false

controllerteam:
clusterrole:
enabled: false

heapster:
enabled: false
rbac:
create: false
{{- end }}
{{- end }}

gcactivities:
args:
- "gc"
@@ -190,8 +227,20 @@ gcactivities:
cronjob:
enabled: true
schedule: "0/30 * * * *"
{{- if hasKey .Requirements.cluster "strictPermissions" }}
{{- if and (eq .Requirements.cluster.provider "openshift") (.Requirements.cluster.strictPermissions) }}
clusterrole:
enabled: false
{{- end }}
{{- end }}

gcpods:
cronjob:
enabled: true
schedule: "0/30 * * * *"
{{- if hasKey .Requirements.cluster "strictPermissions" }}
{{- if and (eq .Requirements.cluster.provider "openshift") (.Requirements.cluster.strictPermissions) }}
clusterrole:
enabled: false
{{- end }}
{{- end }}
3 changes: 3 additions & 0 deletions env/jxboot-resources/values.tmpl.yaml
Original file line number Diff line number Diff line change
@@ -24,6 +24,9 @@ cluster:
name: ""
{{- if hasKey .Requirements.cluster "provider" }}
provider: {{ .Requirements.cluster.provider }}
{{- end }}
{{- if hasKey .Requirements.cluster "strictPermissions" }}
strictPermissions: {{ .Requirements.cluster.strictPermissions }}
{{- end }}
serverUrl: ""
{{- if .Requirements.ingress.tls.enabled }}
23 changes: 19 additions & 4 deletions env/lighthouse/values.tmpl.yaml
Original file line number Diff line number Diff line change
@@ -11,13 +11,20 @@ git:
name: {{ .Requirements.cluster.gitName | default "github" }}
server: {{ .Requirements.cluster.gitServer | default "https://github.com" }}

service:
name: hook

replicaCount: 2
webhooks:
replicaCount: 2
service:
name: hook

image:
# Deprecated in favor of image.parentRepository but retained for backwards compatibility with old value.
repository: gcr.io/jenkinsxio/lighthouse
parentRepository: gcr.io/jenkinsxio

# Deprecated in favor of webhooks.replicaCount and webhooks.service
replicaCount: 2
service:
name: hook

vault:
{{- if eq .Requirements.secretStorage "vault" }}
@@ -31,3 +38,11 @@ clusterName: {{ .Requirements.cluster.clusterName }}
user: "{{ .Parameters.pipelineUser.username }}"

oauthToken: "{{ .Parameters.pipelineUser.token }}"

{{- if hasKey .Requirements.cluster "strictPermissions" }}
{{- if and (eq .Requirements.cluster.provider "openshift") (.Requirements.cluster.strictPermissions) }}
cluster:
crds:
create: false
{{- end }}
{{- end }}
2 changes: 1 addition & 1 deletion env/parameters.tmpl.schema.json
Original file line number Diff line number Diff line change
@@ -98,7 +98,7 @@
},
"enableDocker": {
"type": "boolean",
"title": "Do you want to configure an external Docker Registry?",
"title": "Do you want to configure non default Docker Registry?",
"description": "By default Jenkins X will use the docker registry from the cloud provider. If you want to configure an external docker registry such as Docker Hub or your own existing public docker registry enter Y"
}
},
12 changes: 12 additions & 0 deletions env/tekton/values.tmpl.yaml
Original file line number Diff line number Diff line change
@@ -22,3 +22,15 @@ auth:
{{- end }}

tillerNamespace: ""

{{- if hasKey .Requirements.cluster "strictPermissions" }}
{{- if and (eq .Requirements.cluster.provider "openshift") (.Requirements.cluster.strictPermissions) }}
rbac:
cluster: false
cluster:
crds:
create: false
resources:
create: false
{{- end }}
{{- end }}
54 changes: 0 additions & 54 deletions env/values.tmpl.yaml
Original file line number Diff line number Diff line change
@@ -6,60 +6,6 @@ tekton:
{{- else }}
enabled: false
{{- end }}
{{- if eq .Requirements.cluster.provider "openshift" }}
rbac:
cluster: false
cluster:
crds:
create: false
resources:
create: false
{{- end }}

{{- if eq .Requirements.cluster.provider "openshift" }}
jenkins-x-platform:
gcpreviews:
clusterrole:
enabled: false

gcactivities:
clusterrole:
enabled: false

gcpods:
clusterrole:
enabled: false

postinstalljob:
clusterrole:
enabled: false

controllerworkflow:
clusterrole:
enabled: false

controllerbuild:
clusterrole:
enabled: false

controllercommitstatus:
clusterrole:
enabled: false

controllerrole:
clusterrole:
enabled: false

controllerteam:
clusterrole:
enabled: false

heapster:
enabled: false
rbac:
create: false
{{- end }}


# Use cert-manager 0.11 CRDs/APIs with Dex
dex:
12 changes: 12 additions & 0 deletions jenkins-x.yml
Original file line number Diff line number Diff line change
@@ -267,6 +267,18 @@ pipelineConfig:
command: jx
dir: /workspace/source/repositories
name: update-webhooks
- args:
- step
- helm
- apply
- --boot
- --remote
- --no-vault
- --name
- tekton-dashboard
command: jx
dir: /workspace/source/systems/tekton-dashboard
name: install-tekton-dashboard
- args:
- step
- verify
2 changes: 1 addition & 1 deletion jx-requirements.yml
Original file line number Diff line number Diff line change
@@ -32,4 +32,4 @@ storage:
versionStream:
ref: "master"
url: https://github.com/jenkins-x/jenkins-x-versions.git
webhook: prow
webhook: lighthouse
2 changes: 1 addition & 1 deletion kubeProviders/aks/values.tmpl.yaml
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@ jenkins-x-platform:
# lets enable ACR docker builds
DockerConfig: |-
{
"credsStore": "acr-linux"
"credsStore": "acr"
}
docker-registry:
21 changes: 15 additions & 6 deletions kubeProviders/eks/values.tmpl.yaml
Original file line number Diff line number Diff line change
@@ -2,17 +2,26 @@
jenkins-x-platform:
PipelineSecrets:

# lets enable ECR docker builds
{{- if eq .Parameters.enableDocker true }}
DockerConfig: |-
{
"auths":{
{{ .Parameters.docker.url | quote }}:
{
"auth": {{ printf "%s:%s" .Parameters.docker.username .Parameters.docker.password | b64enc | quote}},
"email": {{ .Parameters.docker.email | quote}}
}
}
}
{{- else}}
# lets enable ECR Docker builds
DockerConfig: |-
{
{{- if .Requirements.cluster.registry }}
"credHelpers": {
"{{ .Requirements.cluster.registry }}": "ecr-login"
}
{{- else }}
"credsStore": "ecr-login"
{{- end }}
}

{{- end}}

docker-registry:
enabled: false
15 changes: 14 additions & 1 deletion kubeProviders/gke/values.tmpl.yaml
Original file line number Diff line number Diff line change
@@ -3,7 +3,19 @@
jenkins-x-platform:
PipelineSecrets:

# lets enable GCR docker builds
{{- if eq .Parameters.enableDocker true }}
DockerConfig: |-
{
"auths":{
{{ .Parameters.docker.url | quote }}:
{
"auth": {{ printf "%s:%s" .Parameters.docker.username .Parameters.docker.password | b64enc | quote}},
"email": {{ .Parameters.docker.email | quote}}
}
}
}
{{- else}}
# lets enable GCR Docker builds
DockerConfig: |-
{
"credHelpers": {
@@ -14,6 +26,7 @@ jenkins-x-platform:
"staging-k8s.gcr.io": "gcr"
}
}
{{- end}}

docker-registry:
{{- if eq .Requirements.webhook "jenkins" }}
1 change: 1 addition & 0 deletions systems/acme/templates/cert-manager-prod-issuer.yaml
Original file line number Diff line number Diff line change
@@ -18,6 +18,7 @@ spec:
- "{{ .Values.cluster.domain }}"
# ACME DNS-01 provider configurations
dns01:
cnameStrategy: {{ .Values.cnameStrategy | default "None" }}
{{- if eq .Values.cluster.provider "gke" }}
clouddns:
# The project in which to update the DNS zone
1 change: 1 addition & 0 deletions systems/acme/templates/cert-manager-staging-issuer.yaml
Original file line number Diff line number Diff line change
@@ -18,6 +18,7 @@ spec:
- "{{ .Values.cluster.domain }}"
# ACME DNS-01 provider configurations
dns01:
cnameStrategy: {{ .Values.cnameStrategy | default "None" }}
{{- if eq .Values.cluster.provider "gke" }}
clouddns:
# The project in which to update the DNS zone
3 changes: 3 additions & 0 deletions systems/acme/values.tmpl.yaml
Original file line number Diff line number Diff line change
@@ -18,3 +18,6 @@ certmanager:
email: "{{ .Requirements.ingress.tls.email }}"
enabled: {{ .Requirements.ingress.tls.enabled }}
{{- end }}

# Valid values are 'None' and 'Follow'
cnameStrategy: Follow
7 changes: 7 additions & 0 deletions systems/tekton-dashboard/Chart.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
apiVersion: v1
appVersion: 0.4.1
description: Tekton Dashboard Chart
maintainers:
- name: Team
name: tekton-dashboard
version: "1"
Loading