Skip to content

Commit 509b59e

Browse files
bnoordhuischrisdickinson
authored andcommitted
deps: enable v8 postmortem debugging again
Cherry-pick https://codereview.chromium.org/1033733003 from upstream and re-enable postmortem debugging. PR-URL: #1232 Reviewed-By: Fedor Indutny <[email protected]>
1 parent 01652c7 commit 509b59e

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

common.gypi

+2-3
Original file line numberDiff line numberDiff line change
@@ -20,17 +20,16 @@
2020
# Enable disassembler for `--print-code` v8 options
2121
'v8_enable_disassembler': 1,
2222

23-
# Disable support for postmortem debugging, continuously broken.
24-
'v8_postmortem_support%': 'false',
25-
2623
# Don't bake anything extra into the snapshot.
2724
'v8_use_external_startup_data%': 0,
2825

2926
'conditions': [
3027
['OS == "win"', {
3128
'os_posix': 0,
29+
'v8_postmortem_support%': 'false',
3230
}, {
3331
'os_posix': 1,
32+
'v8_postmortem_support%': 'true',
3433
}],
3534
['GENERATOR == "ninja" or OS== "mac"', {
3635
'OBJ_DIR': '<(PRODUCT_DIR)/obj',

deps/v8/tools/gen-postmortem-metadata.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@
9191
{ 'name': 'prop_idx_first',
9292
'value': 'DescriptorArray::kFirstIndex' },
9393
{ 'name': 'prop_type_field',
94-
'value': 'FIELD' },
94+
'value': 'DATA' },
9595
{ 'name': 'prop_type_mask',
9696
'value': 'PropertyDetails::TypeField::kMask' },
9797
{ 'name': 'prop_index_mask',

0 commit comments

Comments
 (0)