Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: detect node stream with hasOwnProperty #33

Merged
merged 3 commits into from
Apr 8, 2020
Merged

fix: detect node stream with hasOwnProperty #33

merged 3 commits into from
Apr 8, 2020

Conversation

achingbrain
Copy link
Member

Sometimes .writable is false due to a race condition so use hasOwnProperty instead.

Also destroys the stream when we are done with the iterator reguardless.

@achingbrain achingbrain requested a review from hugomrdias April 8, 2020 12:33
@hugomrdias hugomrdias merged commit 1c1d894 into master Apr 8, 2020
@hugomrdias hugomrdias deleted the fix/destroy-stream-before-return branch April 8, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugomrdias hugomrdias hugomrdias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achingbrain @hugomrdias