Skip to content

Commit 28b6d09

Browse files
AndrewFinlayJaKXz
authored andcommitted
fix: missing command temp-directory (#928)
* Fix missing command temp-directory After changing tempDirectory to tempDir, with a fallback for tempDirectory, the default values set in the 'temp-dir' yargs option were being used rather than falling back to tempDirectory and then the default temp dir. This change removes the yargs default value for the option 'temp-dir'. This means the statement that assigns '_tempDirectory' in 'index.js' attempts to use temp-dir, then temp-directory, then the default value. This is now under test with some new test cases that show: - tempDir is preferred to tempDirectory - tempDirectory is used if tempDir isn't set - that we fall back to the '.nyc_output' dir if neither tempDir or tempDirectory are set. * Alternate implementation Maintains notice of default temp-dir in help output. Removed tests as I'm not confident with these right now, will take another look when I get some time. Fixes #927.
1 parent 40afc5f commit 28b6d09

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ function NYC (config) {
4141
this.config = config
4242

4343
this.subprocessBin = config.subprocessBin || path.resolve(__dirname, './bin/nyc.js')
44-
this._tempDirectory = config.tempDir || config.tempDirectory || './.nyc_output'
44+
this._tempDirectory = config.tempDirectory || config.tempDir || './.nyc_output'
4545
this._instrumenterLib = require(config.instrumenter || './lib/instrumenters/istanbul')
4646
this._reportDir = config.reportDir || 'coverage'
4747
this._sourceMap = typeof config.sourceMap === 'boolean' ? config.sourceMap : true

0 commit comments

Comments
 (0)