Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We are skipping tests regardless of platform. #109

Closed
jamestalmage opened this issue Dec 20, 2015 · 1 comment
Closed

We are skipping tests regardless of platform. #109

jamestalmage opened this issue Dec 20, 2015 · 1 comment

Comments

@jamestalmage
Copy link
Member

is-windows returns a function instead of the advertised boolean: https://github.com/jonschlinkert/is-windows/issues/2

That means

if (isWindows) return done()

always skips the test
@jamestalmage jamestalmage mentioned this issue Dec 20, 2015
Merged
@bcoe
Copy link
Member

bcoe commented Dec 25, 2015

@jamestalmage I believe this issue is addressed in the branch you're about to land? reopen if I'm wrong.

@bcoe bcoe closed this as completed Dec 25, 2015
@snyk-bot snyk-bot mentioned this issue Mar 12, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bcoe @jamestalmage