Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node v0.10 exits 0 on failed coverage check #384

Closed
isaacs opened this issue Sep 7, 2016 · 0 comments · Fixed by #386
Closed

Node v0.10 exits 0 on failed coverage check #384

isaacs opened this issue Sep 7, 2016 · 0 comments · Fixed by #386

Comments

@isaacs
Copy link
Collaborator

isaacs commented Sep 7, 2016

Expected Behavior

Should exit with status code 1.

$ node -v
v4.5.0

$ nyc check-coverage --branches=100
ERROR: Coverage for lines (42.78%) does not meet global threshold (90%)
ERROR: Coverage for branches (30.21%) does not meet global threshold (100%)

$ echo $?
1

Observed Behavior

On Node 0.10, it exits with code 0.

$ node -v
v0.10.46

$ nyc check-coverage --branches=100
ERROR: Coverage for lines (42.78%) does not meet global threshold (90%)
ERROR: Coverage for branches (30.21%) does not meet global threshold (100%)

$ echo $?
0

Forensic Information

Operating System: the operating system you observed the issue on.

Darwin

Environment Information: information about your project's environment, see instructions below:

https://gist.github.com/isaacs/14d723f80c0c3a9cccc05f4adaeddaf2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant