Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of --all is broken when instrumentation is disabled #509

Closed
wbyoung opened this issue Jan 28, 2017 · 2 comments
Closed

Use of --all is broken when instrumentation is disabled #509

wbyoung opened this issue Jan 28, 2017 · 2 comments

Comments

@wbyoung
Copy link
Contributor

wbyoung commented Jan 28, 2017

An attempt was made to fix this in #482 and rolled back in 25aec77.

See https://github.com/wbyoung/nyc-issue-482-example and discussion on #482 for a full example of the problem.

@bcoe
Copy link
Member

bcoe commented Jan 29, 2017

@wbyoung I think I've got to the bottom of this issue for you:

https://github.com/wbyoung/nyc-issue-482-example

I'm trying to catch up on pull-requests this weekend across a few projects, so haven't had a chance to the exact root cause -- but it seems to ultimately relate to the order of operations that processes are spawned and that babel-register is applied.

Give this solution a shot and if you confirm that it's working, I'd love help documenting this in the README.

@wbyoung
Copy link
Contributor Author

wbyoung commented Jan 31, 2017

@bcoe that does work. Thanks so much for the help!

Ideally, I think it'd be nice if it wasn't required. As is, the documentation for getting this set up is pretty clear. I think it'd be better to try to avoid adding a section like:

If you've got this all set up and working, but you want to use this one flag, make sure you enable this other thing because internally it's being processed in this way.

For the vast majority of users, this will just be noise. If there's an (easy) way to fix it (even if it's months from now), that'd probably be better than complicating the setup docs.

Just my opinion, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants